Closed
Bug 1145746
Opened 9 years ago
Closed 9 years ago
[Accessibility] Delete confirmation dialog is not elusively visible to the screen reader.
Categories
(Firefox OS Graveyard :: Gaia::Video, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yzen, Assigned: yzen)
References
Details
(Keywords: access)
Attachments
(1 file)
When delete confirmation dialog is shown, screen reader can still step into the underneath content because the app-container is not hidden.
Comment 1•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8580848 -
Flags: review?(rnicoletti)
Comment 2•9 years ago
|
||
Comment on attachment 8580848 [details] [review] [gaia] yzen:bug-1145746 > mozilla-b2g:master I'm uncomfortable associating the 'info-view' class with the 'confirm dialog' because the two are not related. Instead of adding another class ('confirm-dialog' or something similar), which is perfectly fine btw, you could choose to remove the 'info-view', 'overlay','options-view', and 'in-use-overlay' classes and introduce one new class ('app-hidden' or something like that). I'll leave it up to you. Either approach is fine with me.
Attachment #8580848 -
Flags: review?(rnicoletti) → review-
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8580848 [details] [review] [gaia] yzen:bug-1145746 > mozilla-b2g:master Updated based on your comment. I opted for using confirm-dialog class because it makes handling visibility easier when there's a chance of 2 overlays being present at the same time (when removing one the other one will still be present since its visibility is handled independently).
Attachment #8580848 -
Flags: review- → review?(rnicoletti)
Comment 4•9 years ago
|
||
Comment on attachment 8580848 [details] [review] [gaia] yzen:bug-1145746 > mozilla-b2g:master The change looks good. However, after applying the patch I'm not seeing 'display: none' applied to the 'app-container' div when the 'confirm-dialog' overlay is displayed (I'm not seeing it applied in 'info-view' or 'options-view' either). Shouldn't I be seeing 'display: none' applied to the app-container div?
Flags: needinfo?(yzenevich)
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Russ Nicoletti [:russn] from comment #4) > Comment on attachment 8580848 [details] [review] > [gaia] yzen:bug-1145746 > mozilla-b2g:master > > The change looks good. However, after applying the patch I'm not seeing > 'display: none' applied to the 'app-container' div when the 'confirm-dialog' > overlay is displayed (I'm not seeing it applied in 'info-view' or > 'options-view' either). Shouldn't I be seeing 'display: none' applied to the > app-container div? Hi Russ, I just updated the PR with master that has bug 1143862 merged in. It applies visibility: hidden instead of display: none to the #app-container to ensure title truncation works.
Flags: needinfo?(yzenevich)
Comment 6•9 years ago
|
||
Comment on attachment 8580848 [details] [review] [gaia] yzen:bug-1145746 > mozilla-b2g:master Thanks for the explanation (comment 5).
Attachment #8580848 -
Flags: review?(rnicoletti) → review+
Assignee | ||
Comment 7•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/5f4c9281b425f3fdb21e6cd9d29e2ca0a21bffba
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•