Closed
Bug 1145292
Opened 9 years ago
Closed 9 years ago
IPC Proxy for ImageAccessible
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
Details
Attachments
(3 files)
9.91 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
10.87 KB,
patch
|
Details | Diff | Splinter Review | |
10.57 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8580205 -
Flags: review?(tbsaunde+mozbugs)
Comment 1•9 years ago
|
||
Comment on attachment 8580205 [details] [diff] [review] v1 > Accessible* IdToAccessible(const uint64_t& aID); > HyperTextAccessible* IdToHyperTextAccessible(const uint64_t& aID); >+ ImageAccessible* IdToImageAccessible(const uint64_t& aID); I think it could be const, and is there some reason we haven't been making these private? >+ >+ prio(high) sync ImagePosition(uint64_t aID, uint32_t aCoordType) returns (nsIntPoint aRetVal); >+ prio(high) sync ImageSize(uint64_t aID) returns (nsIntSize aRetVal); some reason you changed to returns (... ? I don't care just curious
Attachment #8580205 -
Flags: review?(tbsaunde+mozbugs) → review+
Assignee | ||
Comment 2•9 years ago
|
||
Oh, the space before (. That is just a mistake. IdtoFoo would be yes private and const
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 4•9 years ago
|
||
Looks like MOZ_OVERRIDE -> override causes some merging problems.
Keywords: checkin-needed
Assignee | ||
Comment 5•9 years ago
|
||
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ff253e22f9b
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9ff253e22f9b
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•