Closed
Bug 1145279
Opened 9 years ago
Closed 9 years ago
Typo in accessibility-key-hint
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(b2g-v2.2 fixed, b2g-master fixed)
RESOLVED
FIXED
2.2 S8 (20mar)
People
(Reporter: Tonnes, Assigned: yzen)
Details
(Keywords: late-l10n)
Attachments
(1 file)
46 bytes,
text/x-github-pull-request
|
kgrandon
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details | Review |
The accessibility-key-hint entity in accessibility.properties currently says "Prese and hold to activate". The typo should be clear enough.
Reporter | ||
Updated•9 years ago
|
Summary: Typor in accessibility-key-hint → Typo in accessibility-key-hint
Comment 1•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8580198 -
Flags: review?(kgrandon)
Assignee | ||
Comment 2•9 years ago
|
||
As discussed in #l10n changing press to tap to be consistent with the rest of the hints.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Comment 3•9 years ago
|
||
Comment on attachment 8580198 [details] [review] [gaia] yzen:bug-1145279 > mozilla-b2g:master You need to update the key as well, and every place the key is used. That's how localizers become aware of the changes.
Attachment #8580198 -
Flags: review?(kgrandon)
Comment 4•9 years ago
|
||
Flag me after the changes and I will take another look. Thanks!
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Kevin Grandon :kgrandon from comment #3) > Comment on attachment 8580198 [details] [review] > [gaia] yzen:bug-1145279 > mozilla-b2g:master > > You need to update the key as well, and every place the key is used. That's > how localizers become aware of the changes. I talked to flod and he said no need for the key update with this typo.
Comment 6•9 years ago
|
||
Comment on attachment 8580198 [details] [review] [gaia] yzen:bug-1145279 > mozilla-b2g:master Thanks for the clarification that we don't need a new key. R=me.
Attachment #8580198 -
Flags: review+
Assignee | ||
Comment 7•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/d2f10e0fa18f3171c8b584e696241df7ddb07c82
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8580198 [details] [review] [gaia] yzen:bug-1145279 > mozilla-b2g:master [Approval Request Comment] Fixing a typo in screen reader key interaction hint [Bug caused by] (feature/regressing bug #): bug 1134097 [User impact] if declined: if declined screen reader will incorrectly pronounce Press as Prese [Testing completed]: on device [Risk to taking this patch] (and alternatives if risky): low [String changes made]: https://github.com/mozilla-b2g/gaia/pull/28988/files#diff-832ba08de6e4e23b203d15ffd21706aa
Attachment #8580198 -
Flags: approval-gaia-v2.2?
Updated•9 years ago
|
Attachment #8580198 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Comment 9•9 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/c8136ef4094fc5509551ab7b1d5f6141491f00ef
You need to log in
before you can comment on or make changes to this bug.
Description
•