Closed Bug 1143227 Opened 9 years ago Closed 5 years ago

Android 4.0 mochitest-3 fires 4 assertions in test_conformance__textures__texture-npot-video.html

Categories

(Core :: Audio/Video: Playback, defect, P4)

Product:
Core
Component:
Audio/Video: Playback
Version:
39 Branch
Platform:
ARM
Android
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: KWierso, Assigned: dbaron)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

logcat snippet from the test
34.13 KB, text/plain
Details 
15:00:55 INFO - 438 INFO TEST-OK | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__texture-complete.html | took 1489ms
15:00:55 INFO - 439 INFO TEST-START | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__texture-formats-test.html
15:00:55 INFO - 440 INFO TEST-OK | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__texture-formats-test.html | took 1763ms
15:00:55 INFO - 441 INFO TEST-START | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__texture-mips.html
15:00:55 INFO - 442 INFO TEST-OK | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__texture-mips.html | took 2353ms
15:00:55 INFO - 443 INFO TEST-START | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__texture-npot-video.html
15:00:55 INFO - 444 INFO TEST-OK | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__texture-npot-video.html | took 2232ms
15:00:55 INFO - 445 INFO TEST-UNEXPECTED-ERROR | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__texture-npot-video.html | Assertion count 4 is greater than expected range 0-0 assertions.
15:00:55 INFO - TEST-INFO
15:00:55 INFO - 446 INFO TEST-START | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__texture-transparent-pixels-initialized.html
15:00:55 INFO - 447 INFO TEST-OK | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__texture-transparent-pixels-initialized.html | took 2773ms
15:00:55 INFO - 448 INFO TEST-START | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__typedarrays__array-buffer-crash.html
15:00:55 INFO - 449 INFO TEST-OK | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__typedarrays__array-buffer-crash.html | took 1040ms
I suspect this test was only running in mochitest-gl, not mochitest-3, before bug 1083347 (we don't run mochitest-gl on Android Debug). Bug 1141771 would resolve this by keeping gl tests out of plain mochitest.
I'm not going to be around for much longer tonight, inbound is closed until something can clear this up.
I confirmed from the log that on the run prior to https://hg.mozilla.org/integration/mozilla-inbound/rev/51ab04cf3b55 (i.e., 4777149382bc) we had in mochitest-2:

12:47:05     INFO -  TEST-START | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__texture-npot-video.html
12:47:05     INFO -  TEST-SKIP | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__texture-npot-video.html | took 0ms

whereas with it we have, in mochitest-3:

14:07:02     INFO -  443 INFO TEST-START | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__texture-npot-video.html
14:07:02     INFO -  444 INFO TEST-OK | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__texture-npot-video.html | took 2277ms
14:07:02     INFO -  445 INFO TEST-UNEXPECTED-ERROR | dom/canvas/test/webgl-conformance/_wrappers/test_conformance__textures__texture-npot-video.html | Assertion count 4 is greater than expected range 0-0 assertions.

I think the right thing to do here is annotate it as being known to assert.

(I'm curious, however, as to why mochitest-gl is a separate thing, and whether bug 1083347 might have broken that.)
Annotated the known assertions:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ab42fa86179

Leaving the bug open to actually fix them.
Keywords: leave-open
This is from the blob uploaded from the first failing run:
https://treeherder.mozilla.org/logviewer.html#?job_id=7606475&repo=mozilla-inbound

This shows that the assertions are:
###!!! ASSERTION: Network state should be loading: 'mNetworkState == nsIDOMHTMLMediaElement::NETWORK_LOADING', file /builds/slave/m-in-and-api-11-d-000000000000/build/dom/html/HTMLMediaElement.cpp, line 1008
###!!! ASSERTION: Should delay load event (if in document) during load: 'mDelayingLoadEvent', file /builds/slave/m-in-and-api-11-d-000000000000/build/dom/html/HTMLMediaElement.cpp, line 1139
###!!! ASSERTION: Network state should be loading: 'mNetworkState == nsIDOMHTMLMediaElement::NETWORK_LOADING', file /builds/slave/m-in-and-api-11-d-000000000000/build/dom/html/HTMLMediaElement.cpp, line 1008
###!!! ASSERTION: Should delay load event (if in document) during load: 'mDelayingLoadEvent', file /builds/slave/m-in-and-api-11-d-000000000000/build/dom/html/HTMLMediaElement.cpp, line 1139
Changing component based on the assertion.

Also changing summary; given that the bug started happening because we started running the test in debug builds, some of the information there is less useful.
Component: Canvas: WebGL → Video/Audio
Summary: Android 4.0 mochitest-3 permafailing with test_conformance__textures__texture-npot-video.html | Assertion count 4 is greater than expected range 0-0 assertions. after bug 1083347 landed → Android 4.0 mochitest-3 fires 4 assertions in test_conformance__textures__texture-npot-video.html
we have had duplicated webgl tests on desktop for a long time, now we have parity on android so we can then finally move forward on bug 1143218.  Quite possible we can get the webgl stuff fixed up asap
Flags: needinfo?(jmaher)
This changed a generated file. The change must be moved to the non-generated source.
Component: Audio/Video → Graphics
I don't think this belongs to the Graphics component considering the failing assertions are in nsIDOMHTMLMediaElement and related to networks stuff according to comment 23.

So I am tempted to move this bug back to Audio/Video, but maybe I missed something ?
Flags: needinfo?(mreavy)
Whiteboard: [gfx-noted]
I think you're right, Nical.  Moving this to Audio/Video:Playback.
Component: Graphics → Audio/Video: Playback
Flags: needinfo?(mreavy)
The leave-open keyword is there and there is no activity for 6 months.
:drno, maybe it's time to close this bug?
Flags: needinfo?(drno)
Flags: needinfo?(drno)
Rank: 35
Priority: -- → P4

The leave-open keyword is there and there is no activity for 6 months.
:drno, maybe it's time to close this bug?

Flags: needinfo?(drno)

The patch from comment 22 no longer appears to be in the tree, so I'm going to call this fixed.

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(drno)
Resolution: --- → FIXED
Assignee: nobody → dbaron
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: