Xidorn Quan [:xidorn] UTC+11 Assignee
	Description • 9 years ago

According to the MDN page, we have implemented all values of unicode-bidi, but some of them are still prefixed, including: isolate, plaintext, and isolate-override.

The corresponding spec CSS Writing Modes Level 3 has been CR, which means we should be able to safely ship those values unprefixed.

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 1 • 9 years ago

It seems our current impl of value "isolate" passes all CSSWG tests, while "isolate-override" and "plaintext" still have some problems.

The tests we do not pass includes:
* bidi-isolate-override-005 ~ -010,
* bidi-plaintext-003, -005, -006, -008, -009, -011

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 2 • 9 years ago

For whoever interested in testing Firefox with support of unprefixed unicode-bidi values, you can download the builds here: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/xquan@mozilla.com-71a717058411/

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 3 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/61486/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61486/

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 4 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/61488/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61488/

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 5 • 8 years ago

Comment on attachment 8766680 [details]
Bug 1141895 part 1 - Add unprefixed values for unicode-bidi.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61486/diff/1-2/

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 6 • 8 years ago

Comment on attachment 8766681 [details]
Bug 1141895 part 2 - Use unprefixed unicode-bidi values in internal code.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/61488/diff/1-2/

	Jonathan Kew [:jfkthame]
	Comment 7 • 8 years ago

Comment on attachment 8766680 [details]
Bug 1141895 part 1 - Add unprefixed values for unicode-bidi.

https://reviewboard.mozilla.org/r/61486/#review58388

	Jonathan Kew [:jfkthame]
	Comment 8 • 8 years ago

Comment on attachment 8766681 [details]
Bug 1141895 part 2 - Use unprefixed unicode-bidi values in internal code.

https://reviewboard.mozilla.org/r/61488/#review58390

	Pulsebot
	Comment 9 • 8 years ago

Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6d4dbb717edd
part 1 - Add unprefixed values for unicode-bidi. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/272f65d9e8d0
part 2 - Use unprefixed unicode-bidi values in internal code. r=jfkthame

	Gregory Szorc [:gps]
	Comment 10 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/6d4dbb717edd
https://hg.mozilla.org/mozilla-central/rev/272f65d9e8d0

	Kohei Yoshino [:kohei]
	Comment 11 • 8 years ago

Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/unicode-bidi-values-have-been-unprefixed/

	Jean-Yves Perrier [:teoli]
	Comment 12 • 8 years ago

Updated:
https://developer.mozilla.org/en-US/docs/Web/CSS/unicode-bidi#Browser_compatibility
and
https://developer.mozilla.org/en-US/Firefox/Releases/50#CSS