Tim Nguyen :ntim Reporter
	Description • 9 years ago

      No description provided.

	Jared Wein [:jaws] (please needinfo? me)
	Comment 1 • 9 years ago

For posterity, I *think* the bug comes from this block of code, http://mxr.mozilla.org/mozilla-central/source/layout/style/nsCSSDataBlock.cpp#151

Although Gijs has pointed out that this would mean that the background-color would take the high-contrast color but the text color wouldn't, so I'm not so sure.

	:Gijs (he/him)
	Comment 2 • 9 years ago

No colors ever work in HCM. We just end up picking nice ones for foreground/background, but we seem to pick the background color for outline, instead of the foreground. I don't know why this is.

	David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)
	Comment 4 • 9 years ago

Comment on attachment 8598769 [details] [diff] [review]
Fix the initial value of outline-color to actually be correct

I wonder how we missed this for so long.  (It seems to predate the rule tree landing.)

	Pulsebot
	Comment 5 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/a1fea675c94d

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 6 • 9 years ago

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/b899a9295076 for mochitest-5 orange:

https://treeherder.mozilla.org/logviewer.html#?job_id=9382841&repo=mozilla-inbound

	David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)
	Comment 7 • 9 years ago

Yeah, looks like the big switch statement in:

$("one").addEventListener("transitionend",
  function(event) {
    switch (event.propertyName) {

needs a case for outline-color just like the ones for everything other than border-right-color.

	Pulsebot
	Comment 8 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b43e06f82d6

	Boris Zbarsky [:bzbarsky] Assignee
	Comment 9 • 9 years ago

> Yeah, looks like the big switch statement in:

That, plus adding it to the block with explicit styles passes try.

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 10 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/8b43e06f82d6

	David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)
	Comment 11 • 9 years ago

One thing I noticed while auditing -- the patch in bug 1141607 should have added a started_test() call -- as, probably, should some other changes to the test in the past.  I think we're two short for the listener on #one, and also two short for the listener on the root.  But we're two over for #seven since that listener doesn't call finished_test (and also doesn't check for duplicate events on ::after).

It might be worth seeing if adding the necessary calls makes failures that are currently intermittent more reliable.

	David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)
	Comment 12 • 9 years ago

Er, I meant that for bug 1156451, although it's not entirely inappropriate here.