Andreas Tolfsen ❲:ato❳ Reporter
	Description • 9 years ago

The marionette.keys.Keys class should be imported into the marionette namespace alongside other utility packages: http://hg.mozilla.org/mozilla-central/file/eab4a81e4457/testing/marionette/driver/marionette_driver/__init__.py

This will make it possible to use the import statement:

    from marionette import Keys

Instead of:

    from marionette.keys import Keys

	MikeLing
	Comment 1 • 9 years ago

Hi~ I'm very interesting in this bug and I have experience to make contribution to Mozilla. Could you give this bug to me? Thanks a lot :-)

	Andreas Tolfsen ❲:ato❳ Reporter
	Comment 2 • 9 years ago

MikeLing: Assigned it to you.  I'm known as ato in #ateam on irc.mozilla.org if you need any help.

	Andreas Tolfsen ❲:ato❳ Reporter
	Comment 4 • 9 years ago

Comment on attachment 8600548 [details] [diff] [review]
bug-1141050-fix.patch

Review of attachment 8600548 [details] [diff] [review]:
-----------------------------------------------------------------

Did you check that this patch actually works?  AFAIK "marionette" isn't our module and it especially isn't one that contains the class Keys.

I think what you want to do here is:

    from marionette_driver.keys import Keys

	MikeLing
	Comment 5 • 9 years ago

(In reply to Andreas Tolfsen (:ato) from comment #4)

Sorry, could you tell me how to test my work before I commit this patch? Build all mozilla source code is a hard work for me. Thank you :)

	Andreas Tolfsen ❲:ato❳ Reporter
	Comment 6 • 9 years ago

(In reply to MikeLing from comment #5)
> (In reply to Andreas Tolfsen (:ato) from comment #4)
> 
> Sorry, could you tell me how to test my work before I commit this patch?
> Build all mozilla source code is a hard work for me. Thank you :)

You need to set your Python path so that the development version of marionette_driver is pulled in when you import marionette_driver.

Typically you'd do this by creating a virtualenv, activating that, and calling `python setup.py develop` in testing/marionette/driver.

	MikeLing
	Comment 7 • 9 years ago

Hmm, I open a python shell and "import marionette_driver" and it seems works well. I hope this patch will work:)

	Andreas Tolfsen ❲:ato❳ Reporter
	Comment 8 • 9 years ago

That looks good to me, but can you please generate a patch file instead of a diff?

See this about how a commit message should look:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities
(In particular you need to include r=ato to indicate I approved it.)

	MikeLing
	Comment 9 • 9 years ago

(In reply to Andreas Tolfsen (:ato) from comment #8)
Sorry, I can't find my patch file after I type "hg qnew name.patch". Could you tell me how could I give the patch file to you? Thanks!

	Andreas Tolfsen ❲:ato❳ Reporter
	Comment 10 • 9 years ago

(In reply to MikeLing from comment #9)
> (In reply to Andreas Tolfsen (:ato) from comment #8)
> Sorry, I can't find my patch file after I type "hg qnew name.patch". Could
> you tell me how could I give the patch file to you? Thanks!

If you commit your changes on your patch queue, you can do `hg export -o FILE -r REV`, where REV is the last commit ID or SHA.  You can find that if you look at `hg log -r.`.

	MikeLing
	Comment 11 • 9 years ago

(In reply to Andreas Tolfsen (:ato) from comment #10)

The information in FILE is:
> # HG changeset patch
> # User MikeLing <sabergeass@gmail.com>
> # Date 1430817526 -28800
> #      Tue May 05 17:18:46 2015 +0800
> # Node ID 3ba606a3e3c1bc0a24c38711a03062c96c0a048c
> # Parent  c63234b1e62c36a4f20b1d9e192df4a1a30f780c
> [mq]: fix_1141050.patch

What should I do next?

	Andreas Tolfsen ❲:ato❳ Reporter
	Comment 12 • 9 years ago

Can you paste FILE/fix_1141050.patch somewhere?

	MikeLing
	Comment 13 • 9 years ago

(In reply to Andreas Tolfsen (:ato) from comment #12)
> Can you paste FILE/fix_1141050.patch somewhere?

No, I can't because FILE isn't a directory.

First of all, I type ' hg qseries -v -s' and it's return:
> 0 A bug-1141050-fix: Bug 1141050: Import marionette.keys.Keys into marionette...
> 1 A fix_1141050.patch: 

Then, I type `hg export -o FILE -r fix_1141050.patch`

But FILE which this order generate a file named FILE not a directory.

	MikeLing
	Comment 14 • 9 years ago

(In reply to Andreas Tolfsen (:ato) from comment #12)
> Can you paste FILE/fix_1141050.patch somewhere?

Maybe we could talk about this on IRC :)

	Andreas Tolfsen ❲:ato❳ Reporter
	Comment 15 • 9 years ago

Comment on attachment 8600900 [details] [diff] [review]
bug-1141050-fix-V2.patch

Review of attachment 8600900 [details] [diff] [review]:
-----------------------------------------------------------------

Yes we can.

	Andrew
	Comment 16 • 9 years ago

Since there hasn't been movement on this bug, can this be marked as open? Also what are the other utility packages apart from Keys?

Are these all the utility packages? 

errors, by, decorators, expected, geckoinstance,
gestures, keys, marionette, selection, wait,
application_cache, date_time_value 


From: http://hg.mozilla.org/mozilla-central/file/eab4a81e4457/testing/marionette/driver/marionette_driver/__init__.py

	MikeLing
	Comment 17 • 9 years ago

Sure(In reply to Andrew from comment #16)
> Since there hasn't been movement on this bug, can this be marked as open?

Sure! sorry for later reply, I would like to unassigned this bug from myself and let other people who want this to take it :)

	Andreas Tolfsen ❲:ato❳ Reporter
	Comment 18 • 9 years ago

Actually, looking at the remainder of the package namespace the current approach does make sense and harmonises with what Selenium is doing.  I'm going to close this bug in order not to create more inconsistency.