Olli Pettay [:smaug][bugs@pettay.fi] Assignee
	Description • 9 years ago

      No description provided.

	Olli Pettay [:smaug][bugs@pettay.fi] Assignee
	Comment 1 • 9 years ago

https://tbpl.mozilla.org/?tree=Try&rev=38cf620a65b8

	Trevor Saunders (:tbsaunde)
	Comment 2 • 9 years ago

Comment on attachment 8574442 [details] [diff] [review]
v1

>+  int32_t startOffset = 0, endOffset = 0;
>+  if (accWrap) {
>+    HyperTextAccessible* text = accWrap->AsHyperText();
>+    if (!text || !text->IsTextRole()) {
>+      return nullptr;
>+    }
>+
>+    text->SelectionBoundsAt(aSelectionNum, &startOffset, &endOffset);
>+  } else if (ProxyAccessible* proxy = GetProxy(ATK_OBJECT(aText))) {
>+    proxy->SelectionBoundsAt(aSelectionNum, &startOffset, &endOffset);
>+  } else {
>     return nullptr;
>+  }
> 
>-  HyperTextAccessible* text = accWrap->AsHyperText();
>-  if (!text || !text->IsTextRole())
>-    return nullptr;
>+  *aStartOffset = startOffset;
>+  *aEndOffset = endOffset;
> 
>-  int32_t startOffset = 0, endOffset = 0;
>-  text->SelectionBoundsAt(aSelectionNum, &startOffset, &endOffset);
>-
>-    *aStartOffset = startOffset;
>-    *aEndOffset = endOffset;
>-
>-    return getTextCB(aText, *aStartOffset, *aEndOffset);
>+  return getTextCB(aText, *aStartOffset, *aEndOffset);

isn't two ipc calls racy? since the text can change between them?

	Olli Pettay [:smaug][bugs@pettay.fi] Assignee
	Comment 3 • 9 years ago

Yeah, I was wondering about that.
I guess I need to change procy::SelectionBoundsAt a bit.

	Trevor Saunders (:tbsaunde)
	Comment 4 • 9 years ago

(In reply to Olli Pettay [:smaug] from comment #3)
> Yeah, I was wondering about that.
> I guess I need to change procy::SelectionBoundsAt a bit.

makes sense

	Olli Pettay [:smaug][bugs@pettay.fi] Assignee
	Comment 6 • 9 years ago

Other platforms may need a bit different kinds of SelectionBoundsAt, but better to implement
those when needed.

	Olli Pettay [:smaug][bugs@pettay.fi] Assignee
	Comment 7 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/d11e756b726f

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 8 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/d11e756b726f