Closed
Bug 1140499
Opened 9 years ago
Closed 9 years ago
IPC Proxy for text/char bounds
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
Details
Attachments
(2 files)
9.29 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
9.30 KB,
patch
|
Details | Diff | Splinter Review |
The actual coordinates should be wrong until bug 1075670 is fixed.
Attachment #8574072 -
Flags: review?(tbsaunde+mozbugs)
Comment 1•9 years ago
|
||
Comment on attachment 8574072 [details] [diff] [review] v1 >+ if (!text || !text->IsTextRole()) { >+ return; >+ } >+ rect = text->CharBounds(aOffset, geckoCoordType); stuff on line after } still seems very weird to me.
Attachment #8574072 -
Flags: review?(tbsaunde+mozbugs) → review+
Assignee | ||
Comment 2•9 years ago
|
||
Sorry, I'm trying to follow this a11y coding style, but missing occasionally. Takes time to get used to it.
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5f0d1845ecc
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d5f0d1845ecc
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•