Chris Cooper [:coop] (he/him) Assignee
	Description • 9 years ago

Among the various improvements we should make:

* update IRC automatically at start/end of reconfig
* don't overwrite previous repo merge data when resuming a previous reconfig
* format times for display output
* output the commands used to format the output and update the wiki. This is extremely useful when the reconfig is only partially successful and we don't want to restart from scratch.

	Chris Cooper [:coop] (he/him) Assignee
	Comment 1 • 9 years ago

(In reply to Chris Cooper [:coop] from comment #0) 
> * update IRC automatically at start/end of reconfig
> * don't overwrite previous repo merge data when resuming a previous reconfig
> * format times for display output
> * output the commands used to format the output and update the wiki. This is
> extremely useful when the reconfig is only partially successful and we don't
> want to restart from scratch.

Addresses the above issues.

Adds a separate script to update irc so it can be replaced easily in the future.

	Jordan Lund (:jlund)
	Comment 2 • 9 years ago

Comment on attachment 8574206 [details] [diff] [review]
[tools] Improvements to end-to-end reconfig script

Review of attachment 8574206 [details] [diff] [review]:
-----------------------------------------------------------------

my fear of one master failing has been mitigated. this is going to be an awesome way to start the week.

::: buildfarm/maintenance/end_to_end_reconfig.sh
@@ +127,5 @@
>      } >>"${RECONFIG_DIR}/hg-${START_TIME}.log" 2>&1
>      return "${HG_RETURN_CODE}"
>  }
>  
> +function show_time () {

lol bash is silly

@@ +422,5 @@
>          {
>              echo "Merging from default"
>              echo
>              hg -R "${RECONFIG_DIR}/${repo}" merge -P default
> +        } >> "${RECONFIG_DIR}/${repo}_preview_changes.txt" 2>/dev/null

nice

@@ +462,5 @@
> +    commit_processing_options+=('--update-bugzilla')
> +fi
> +
> +# Display the commands in advance in case the reconfig fails part way through.
> +if [ "${#commit_processing_options[@]}" -gt 0 ]; then

TIL http://wiki.bash-hackers.org/syntax/pe#string_length

@@ +469,5 @@
> +    for ((i=0; i<${#commit_processing_options[@]}; i+=1)); do
> +        echo -n " '${commit_processing_options[${i}]}'"
> +    done
> +    echo
> +    echo "  * Will run: './update_maintenance_wiki.sh -r \"${RECONFIG_DIR}\" -w \"${RECONFIG_DIR}/${RECONFIG_UPDATE_FILE}\"'"

\o/ ty

@@ +553,2 @@
>  echo "  * Finish timestamp: ${STOP_TIME}"
> +echo "  * Time taken: ${ELAPSED_DISPLAY}"

fancy formatting :) I've stolen your show_time func

::: buildfarm/maintenance/update_irc.sh
@@ +7,5 @@
> +if [ "${MSG}" == "" ]; then
> +    exit 1
> +fi
> +
> +II=`which ii`

/me brew installs ii && mkdirs ~/irc

	Chris Cooper [:coop] (he/him) Assignee
	Comment 3 • 9 years ago

Comment on attachment 8574206 [details] [diff] [review]
[tools] Improvements to end-to-end reconfig script

Review of attachment 8574206 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/tools/rev/cd56ae044b82