Joshua Mitchell (Inactive) Reporter
	Description • 9 years ago

Description:
Email app does not successfully download OGG files. When you click on the download icon it will change to the spinner for a few seconds and then back into the download icon; file does not successfully download

Repro Steps:
1) Update a Flame to 20150305010212
2) Email an OGG file to yourself
3) Launch Email App and access the email
4) Download file

Actual:
OGG file not successfully downloaded

Expected:
file will successfully download. Download icon will change to spinner and then to the eyeball icon that will allow user to the play / preview file

Environmental Variables:
Device: Flame Master
Build ID: 20150305010212
Gaia: eff3321ab4e65da3f906688ebb55ddf1e93d9452
Gecko: 56492f7244a9
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (Master)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0


Repro frequency: 6/6
See attached: logcat

	Joshua Mitchell (Inactive) Reporter
	Comment 1 • 9 years ago

issue also reproduces on 2.2 and 2.1

Device: Flame 2.2 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150305002528
Gaia: 89af288bad6751248ff84504fa898206fee127fe
Gecko: 6d8d294aa8f3
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame 2.1 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150302001220
Gaia: 5d3479fdd438412adee4452720856b6b771fe5cd
Gecko: 9bf4c663241f
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

	Joshua Mitchell (Inactive) Reporter
	Comment 2 • 9 years ago

One of several OGG files used to test

	Peter Bylenga [:PBylenga]
	Comment 3 • 9 years ago

NI on component owner for nomination decision and assignment.

	Joshua Mitchell (Inactive) Reporter
	Comment 4 • 9 years ago

One thing I did notice in the logcat was this: 

03-05 15:05:54.070 11350 11556 I Gecko   : [33mWWAR: failed to save attachment to sdcard Sample_of_"Another_Day_in_Paradise".ogg type: video/ogg[0m
03-05 15:05:54.070 11350 11350 I GeckoDump: DeviceStorage: process save
03-05 15:05:54.110 11350 11556 I Gecko   : [33mWWAR: failed to save attachment to sdcard Sample_of_"Another_Day_in_Paradise"-1425596754082.ogg type: video/ogg[0m



And my media storage is set to save to Internal storage, not sdcard

	Andrew Sutherland [:asuth] (he/him)
	Comment 5 • 9 years ago

The problem is the double-quote characters.  Email doesn't to anything to normalize the filename, so we will naively attempt to save files with potentially quite-illegal filenames as far as sdcards are concerned.  (Since they all usually are formatted FAT32/VFAT)

Per http://en.wikipedia.org/wiki/8.3_filename#Directory_table the following set of characters is not legal:
" * + , / : ; < = > ? \ [ ] |

I'm a bit surprised we've managed to go so far without hitting this, but it probably helps that people probably usually avoid filename characters like this.

I'll briefly investigate whether this is something we should propose that devicestorage handles the mangling on, or whether we should just normalize in email.  (The argument for devicestorage normalizing is that it doesn't really make sense for all callers to have to be aware of the file-system limitations, especially if devices start using a different filesystem with different limitations.  Also because I think FAT has path-length limitations, which are potentially hidden from the devicestorage consumer entirely.)

	Andrew Sutherland [:asuth] (he/him)
	Comment 6 • 9 years ago

Comment on attachment 8573581 [details]
Sample_of_"Another_Day_in_Paradise".ogg

I'm marking the attachment private since the ogg nature is not important and although the sample is short enough for fair use, etc. to be appropriate, there's no advantage to getting into it with copyright bots.

	Teri Wen [:twen]
	Comment 7 • 9 years ago

Not a blocker since the problem is the double-quote characters as comment 5 described. Set tracking flag.

	BMO Automation
	Comment 8 • 6 years ago

Firefox OS is not being worked on