Closed
Bug 1139972
Opened 9 years ago
Closed 9 years ago
IPC Proxy for charAt
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
Details
Attachments
(1 file)
5.62 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8573327 -
Flags: review?(tbsaunde+mozbugs)
Comment 1•9 years ago
|
||
Comment on attachment 8573327 [details] [diff] [review] v1 >+DocAccessibleChild::RecvCharAt(const uint64_t& aID, >+ const int32_t& aOffset, >+ uint16_t* aChar) >+{ >+ HyperTextAccessible* acc = IdToHyperTextAccessible(aID); >+ *aChar = acc && acc->IsTextRole() ? >+ static_cast<uint16_t>(acc->CharAt(aOffset)) : 0; I wonder if it should be allowed to call this on accessible where IsTextRole() returns false, but seems fine for now.
Attachment #8573327 -
Flags: review?(tbsaunde+mozbugs) → review+
Assignee | ||
Comment 2•9 years ago
|
||
Just tried to keep the behavior atk backend has.
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e9fb89350a7
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9e9fb89350a7
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•