Olli Pettay [:smaug][bugs@pettay.fi] Assignee
	Description • 9 years ago

      No description provided.

	Olli Pettay [:smaug][bugs@pettay.fi] Assignee
	Comment 1 • 9 years ago

On IRC you were worried about 'sync SetCaretOffset'. Any particular reason why that would be
more worrisome than other sync stuff?

	Trevor Saunders (:tbsaunde)
	Comment 2 • 9 years ago

(In reply to Olli Pettay [:smaug] (no new review requests before March 8, please) from comment #1)
> On IRC you were worried about 'sync SetCaretOffset'. Any particular reason
> why that would be
> more worrisome than other sync stuff?

Well, the rest of it is conceptually read only and this is not.  In an ideal world it would trigger an event being immediately dispatched, and and so calling into code of the a11y consumers.  However that's not currently the case, and I'm not sure it ever will be.

So currently get and set CaretOffset are non racy, but caret move events are racy  in that there exists a period of time in which the caret has moved but the event has not yet been fired.  If we use sync SetCaretOffset then I think we keep that situation.  Ohter mutating a11y things are mixed DoAction() is the same as async, and TakeFocus() is sync.  I was hoping we wouldn't need to use sync ipc for any mutators, but I guess this is fine for now :(

	Olli Pettay [:smaug][bugs@pettay.fi] Assignee
	Comment 3 • 9 years ago

There is some bizarre linking problem
https://tbpl.mozilla.org/php/getParsedLog.php?id=60609576&tree=Try&full=1#error0

	Olli Pettay [:smaug][bugs@pettay.fi] Assignee
	Comment 4 • 9 years ago

Include -inl.h

	Olli Pettay [:smaug][bugs@pettay.fi] Assignee
	Comment 5 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d66bec2f5e1

	Phil Ringnalda (:philor)
	Comment 6 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/2d66bec2f5e1