:glob ✱ Assignee
	Description • 9 years ago

push_notify is a pretty hot table, and triggers deadlocks from time to time:

Deadlock found when trying to get lock; try restarting transaction [for Statement "REPLACE INTO push_notify(bug_id, delta_ts) VALUES(?, ?)"] at ..

we should catch these and automatically retry (with an upper limit on attempts of course).

	:glob ✱ Assignee
	Comment 2 • 9 years ago

looking at this it's trickier than i first thought, due to the broad scope of the bug transaction.

i'll probably move the push_notify update so it executes after the bug transaction has been committed, which may make it easier to retry.

	:glob ✱ Assignee
	Comment 3 • 9 years ago

i started looking at adding more hooks akin to bug_after_create, but that quickly got complicated.  instead i've added a hook to the request cleanup method and insert the rows there.

	David Lawrence [:dkl]
	Comment 4 • 9 years ago

Comment on attachment 8576036 [details] [diff] [review]
1138767_1.patch

Review of attachment 8576036 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

	:glob ✱ Assignee
	Comment 5 • 9 years ago

To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   03a2eac..0f2b779  master -> master