Closed
Bug 1136241
Opened 9 years ago
Closed 9 years ago
[AccessFu] Make sure hints are localizeable.
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: yzen, Assigned: yzen)
Details
Attachments
(1 file)
3.52 KB,
patch
|
eeejay
:
review+
|
Details | Diff | Splinter Review |
At the moment when we generate a hint string, it might contain spaces because of the role strings. We need to squash them and replace ' ' with '' where possible, similar to what OutputGenerator does.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8568661 -
Flags: review?(eitan)
Comment 2•9 years ago
|
||
Comment on attachment 8568661 [details] [diff] [review] 1136241 patch v1 Review of attachment 8568661 [details] [diff] [review]: ----------------------------------------------------------------- Looks right, good catch on the non-global replace.
Attachment #8568661 -
Flags: review?(eitan) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/18365d823fdf
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/18365d823fdf
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•