Olli Pettay [:smaug][bugs@pettay.fi] Assignee
	Description • 9 years ago

      No description provided.

	Trevor Saunders (:tbsaunde)
	Comment 1 • 9 years ago

Comment on attachment 8568227 [details] [diff] [review]
v1

>+  if (accWrap) {
>+    HyperTextAccessible* textAcc = accWrap->AsHyperText();
>+    return
>+      textAcc->IsDefunct() ? 0 : static_cast<gint>(textAcc->CharacterCount());
>+  }
>+  if (ProxyAccessible* proxy = GetProxy(ATK_OBJECT(aText))) {

blank line after } please

>+    return proxy->CharacterCount();
>+  }
>+  return 0;

same

>+  if (accWrap) {
>+    HyperTextAccessible* text = accWrap->AsHyperText();
>+    if (!text || !text->IsTextRole()) {
>+      return 0;
>+    }
> 
>-  HyperTextAccessible* text = accWrap->AsHyperText();
>-  if (!text || !text->IsTextRole())
>-    return 0;
>-
>-  return text->SelectionCount();
>+    return text->SelectionCount();
>+  }
>+  if (ProxyAccessible* proxy = GetProxy(ATK_OBJECT(aText))) {

and here

	Olli Pettay [:smaug][bugs@pettay.fi] Assignee
	Comment 2 • 9 years ago

Is that some a11y coding style rule?

	Olli Pettay [:smaug][bugs@pettay.fi] Assignee
	Comment 4 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/b60708e9bedb

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 5 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/b60708e9bedb

	Trevor Saunders (:tbsaunde)
	Comment 6 • 9 years ago

(In reply to Olli Pettay [:smaug] from comment #2)
> Is that some a11y coding style rule?

Well, I thought it was more general than just a11y.  Anyway I find it much easier to deal with if you don't mind.