Max Li [:maxli] Assignee
	Description • 9 years ago

On my Nexus 5 with Lollipop, and TalkBack 3.6, I can't explore by touch or swipe to get to the web content area.

	Max Li [:maxli] Assignee
	Comment 1 • 9 years ago

Seems to have occurred between the Jan 21 and 22 nightly builds.

	Marco Zehe (:MarcoZ)
	Comment 2 • 9 years ago

(In reply to Max Li [:maxli] from comment #1)
> Seems to have occurred between the Jan 21 and 22 nightly builds.

That results in this regression range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=540077a30866&tochange=34e2d2bd7ec4

There were no accessibility patches at all landed in that period, so it has to do with something else in the Android codebase that changed.

	Marco Zehe (:MarcoZ)
	Comment 3 • 9 years ago

The first bad revision is:
changeset:   224804:a2651cba8673
user:        Nick Alexander <nalexander@mozilla.com>
date:        Tue Jan 20 15:17:58 2015 -0800
summary:     Bug 1093358 - Add mobile/android AppConstants.jsm. r=mfinkle,f=rnewman

Nick, any idea why this might have broken TalkBack support?

	Nick Alexander :nalexander [he/him]
	Comment 4 • 9 years ago

(In reply to Marco Zehe (:MarcoZ) from comment #3)
> The first bad revision is:
> changeset:   224804:a2651cba8673
> user:        Nick Alexander <nalexander@mozilla.com>
> date:        Tue Jan 20 15:17:58 2015 -0800
> summary:     Bug 1093358 - Add mobile/android AppConstants.jsm.
> r=mfinkle,f=rnewman
> 
> Nick, any idea why this might have broken TalkBack support?

I made a mistake in that patch but it was fixed by Bug 1130812.  That ticket should have landed almost a week ago.  Can you verify that the issue is not in fact fixed by that bug?  If it is not fixed, can you give me steps to reproduce.

It is of course possible I made additional mistakes :/  Thanks so much for finding a regression range and hunting this down.

	Max Li [:maxli] Assignee
	Comment 5 • 9 years ago

It appears to have been a typo in the AppConstants.jsm file.

	Nick Alexander :nalexander [he/him]
	Comment 7 • 9 years ago

Comment on attachment 8566152 [details] [diff] [review]
Patch

Review of attachment 8566152 [details] [diff] [review]:
-----------------------------------------------------------------

You'll also need to fix my error at https://hg.mozilla.org/mozilla-central/annotate/9696d1c4b3ba/mobile/android/modules/moz.build#l37.

Thanks for catching my errors :/

	Max Li [:maxli] Assignee
	Comment 8 • 9 years ago

https://hg.mozilla.org/integration/fx-team/rev/fbb2f8d1a841

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/fbb2f8d1a841

	Marco Zehe (:MarcoZ)
	Comment 10 • 9 years ago

Verified fixed in the 2015-02-19 nightly build.