Olli Pettay [:smaug][bugs@pettay.fi] Assignee
	Description • 9 years ago

More IdToFooAccessible will be added later.

	Trevor Saunders (:tbsaunde)
	Comment 1 • 9 years ago

Comment on attachment 8563049 [details] [diff] [review]
patch

>+DocAccessibleChild::IdToHyperTextAccessible(const uint64_t& aID)

any reason this shouldn't be a const method?

>+{
>+  Accessible* acc = IdToAccessible(aID);
>+  return acc ? acc->AsHyperText() : nullptr;

assert if we have an acc it is HyperText?

> DocAccessibleChild::RecvTextSubstring(const uint64_t& aID,
>                                       const int32_t& aStartOffset,
>                                       const int32_t& aEndOffset,
>                                       nsString* aText)
> {
>-  Accessible* acc = mDoc->GetAccessibleByUniqueID((void*)aID);
>-  if (!acc || !acc->IsHyperText())
>+  HyperTextAccessible* acc = IdToHyperTextAccessible(aID);
>+  if (!acc) {
>     return false;
>+  }

lets return true here since it can happen in normal opteration.

	Olli Pettay [:smaug][bugs@pettay.fi] Assignee
	Comment 3 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/6947464c0fb8

	Carsten Book [:Tomcat]
	Comment 4 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/6947464c0fb8