Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Description • 9 years ago

AccessFu should output the name change accessible event for the current virtual cursor position accessibles.

	Eitan Isaacson [:eeejay]
	Comment 2 • 9 years ago

Comment on attachment 8559830 [details] [diff] [review]
1129955 patch v1

Review of attachment 8559830 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

::: accessible/tests/mochitest/jsat/doc_content_integration.html
@@ +87,5 @@
>      </div>
>      <div id="appframe"></div>
>    </div>
>    <button id="home">Home</button>
> +  <button id="toggle" aria-label="toggle"></button>

The name 'toggle'/'toggled' is a bit misleading. Maybe something more benign like fruit? This could be confusing with aria-checked/aria-pressed, and roles in general.

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 3 • 9 years ago

 https://hg.mozilla.org/integration/mozilla-inbound/rev/d9f7bafe9b47

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 4 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/d9f7bafe9b47

	Yura Zenevich [:yzen] (please use "needinfo") Assignee
	Comment 5 • 9 years ago

Comment on attachment 8559830 [details] [diff] [review]
1129955 patch v1

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment] This a screen reader fix that addressed bug 1069476
Bug caused by (feature/regressing bug #): improvement, not a bug
User impact if declined: The screen reader user will not know if description/text changes for the elements (such as buttons) that the screen reader is positioned on.
Testing completed: Added a11y mochitests + manual
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: None

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 9 years ago

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/84b55ffd50fc