Closed
Bug 1129579
Opened 9 years ago
Closed 9 years ago
user agent parser should set browser = "Firefox for Android" rather than "Firefox"
Categories
(Input Graveyard :: Submission, defect, P1)
Input Graveyard
Submission
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: willkg)
References
Details
(Whiteboard: u=user c=feedback p=1 s=input.2015q1)
A while back we wrote our own user agent parser. I know I know... sounds like the beginning to a hilarious joke, but it's not--it's true. The user agent parser only pays attention to Mozilla browsers because that's all we really cared about. We used to use this data to trigger "mobile-mode", though we don't do that anymore (thank goodness). We continue to use this data to infer data about the product the user is leaving feedback for when certain things line up. The problem we've got is that if the user is using Firefox for Android, the parser sets platform=Android (that's fine) and browser=Firefox (totally not fine). This bug covers changing that behavior so that we set the browser to "Firefox for Android".
Assignee | ||
Comment 1•9 years ago
|
||
Grabbing this and making it a P1 because it blocks work on #1129085 which is somewhat important. The fix here is to: 1. fix the user agent parser 2. go through the tests to make sure they're correct 3. fix any goofy code that is hard-coded to look at the old return values for Firefox for Android user agents 4. shake a finger at Will for every instance of item 3 5. write a data migration updating all the responses to have the proper "browser" field
Assignee | ||
Comment 2•9 years ago
|
||
In a PR except for item 4 which I did in front of a mirror just now: https://github.com/mozilla/fjord/pull/478
Assignee | ||
Comment 3•9 years ago
|
||
Landed in https://github.com/mozilla/fjord/commit/6c360d9f170af6465b0e4e34a87e8bb744aa41b6 Will push later.
Assignee | ||
Comment 4•9 years ago
|
||
Pushed this to prod and verified that it's working.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•9 years ago
|
Whiteboard: u=user c=feedback p= s=input.2015q1 → u=user c=feedback p=1 s=input.2015q1
Updated•7 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•