Closed
Bug 1129085
Opened 9 years ago
Closed 9 years ago
infer version from browser_version for firefox dev
Categories
(Input Graveyard :: Submission, defect, P1)
Input Graveyard
Submission
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: willkg)
References
Details
(Whiteboard: u=user c=feedback p=1 s=input.2015q1)
For Firefox Dev, we should infer the version from the browser_version if the browser is Firefox. When I run the following SQL on today's db dump: select user_agent, product, browser, browser_version from feedback_response where product like 'firefox dev' and created > '2015-01-19' and campaign='' and source='' and version='' and browser_version='37.0'; I get 19 responses that should have the version 37.0, but don't. I think we only infer things if the product name == browser. We need that a little looser. It's possible we can re-use some of the ideas we used when adding the browser_data_browser column to the Product model.
Assignee | ||
Comment 1•9 years ago
|
||
Making this a P1. This should get fixed as soon as we can because otherwise feedback for Firefox Dev Edition is getting lost in the shuffle.
Priority: -- → P1
Assignee | ||
Comment 2•9 years ago
|
||
I'm 95% sure my hypothesis is correct. I started working on the fix and then discovered I need to fix the user agent parser first. Bug #1129579. Grabbing this to work on next.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•9 years ago
|
||
In a PR: https://github.com/mozilla/fjord/pull/479
Assignee | ||
Updated•9 years ago
|
Whiteboard: u=user c=feedback p= s=input.2015q1 → u=user c=feedback p=1 s=input.2015q1
Assignee | ||
Comment 4•9 years ago
|
||
Landed in master: https://github.com/mozilla/fjord/commit/5b5f9b9db01c30b2c1bf4dfc95c790b33a36ccc9 Will push on Monday.
Assignee | ||
Comment 5•9 years ago
|
||
Pushed to prod just now.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•