labratmobi Reporter
	Description • 9 years ago

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20150122214805

Steps to reproduce:

1. Open http://labrat.mobi/games/orbx/ in firefox for android v35
2. Add to home screen
3. Open app again from home screen


Actual results:

1. App opens in a standard browser
2. App icon looks weird 


Expected results:

1. App should open in fullscreen
2. Clean app icon

Note:
In the App mentioned above,
it contains web app capable meta:
<meta name="mobile-web-app-capable" content="yes">

and also standard webapp manifest 
<link rel="manifest" href="manifest.json">

	Aaron Train [:aaronmt]
	Comment 1 • 9 years ago

By adding to home-screen you've thus just generated a shortcut to the page. No session data or site preferences are tied with that instead of making use of our web-app system.

If you publish your web-app on the Mozilla Market or at least offer an install button, Firefox will treat it as a full blown web app native to Android.

https://developer.mozilla.org/en-US/Marketplace
https://developer.mozilla.org/en-US/Apps/Quickstart/Build/Your_first_app#Install_API_functionality

	labratmobi Reporter
	Comment 2 • 9 years ago

This is not about firefox marketplace,

I am talking about this,
https://w3c.github.io/manifest/

and regarding web-app-capable it is already been reported,
https://bugzilla.mozilla.org/show_bug.cgi?id=862516

	Myk Melez [:myk] [@mykmelez]
	Comment 3 • 9 years ago

(In reply to labratmobi from comment #2)
> This is not about firefox marketplace,
> 
> I am talking about this,
> https://w3c.github.io/manifest/

Indeed, if a web app publishes a W3C web app manifest, and the user adds that app to their homescreen, then it should open in fullscreen mode, like an app, rather than in a browser tab, like a web page.

	Andrew Overholt [:overholt]
	Comment 4 • 8 years ago

In case it wasn't clear, the manifest of the page in comment 0 [1] contains |display": "fullscreen",|.

I'm clarifying the summary a bit. Display modes are documented here: https://w3c.github.io/manifest/#display-modes .

[0]
view-source:http://labrat.mobi/games/orbx/manifest.json

	Richard Maher
	Comment 5 • 8 years ago

18 months and counting . . .

	709922234
	Comment 6 • 8 years ago

I think the most important is: display: standalone
Because the full screen can be realized through the Web API

	Richard Maher
	Comment 7 • 8 years ago

Can you https://bugzilla.mozilla.org/show_bug.cgi?id=1126479#c6 explain more?

IIRC in the good ol' days when we still had navigator.mozapps.install we got "fullscreen" which even removed the phone status bar: 
https://developer.mozilla.org/en-US/docs/Web/Manifest

	jcrivard
	Comment 8 • 8 years ago

I'd like to see this fixed as well.  We'd like to move away from Chrome to Firefox for internal web apps and this is holding us back.

	Nevin Chen(Not active on Bugzilla)
	Comment 9 • 8 years ago

Suggest to close the app due to it's duplicated with bug 1285858

	Dale Harvey (:daleharvey)
	Comment 10 • 8 years ago

1285858 is to support standalone mode, fullscreen mode is different (it removes the status bar as well, generally used for games), we should keep this open

	Richard Maher
	Comment 11 • 8 years ago

Note that 1285858 would technically have been a duplicate of this one as this has been open sin Jan 2015 :-(

Can someone please explain to me the difficulty here? You solved all the problems and design questions when you had navigator.mozApps. So what if you don't have an App Store anymore why can you just use the "am I a webapp portions of the code" eg: "Am I launched from the homescreen?"

	Dale Harvey (:daleharvey)
	Comment 12 • 8 years ago

navigator.mozApps was a proprietary API built for Firefox OS that is no longer being used / developed, the underlying plumbing for w3c manifest support needs to be built for this feature and that is being actively worked on, you can track that work @ https://bugzilla.mozilla.org//show_bug.cgi?id=1212648 (+dependencies)

	Richard Maher
	Comment 13 • 7 years ago

WRT: - Mozilla documentation https://developer.mozilla.org/en-US/docs/Web/Manifest#Browser_compatibility 

After adding to homescreen, I am unable to lose any of the browser Chrome with Firefox on Android. (Samsung Galaxy S7)

Chrome and Opera are fine, Samsung browser degrades to supporting "standalone" but Firefox still has the URL, buttons and so on.

	Wesley Huang [:wesley_huang] (EPM) (NI me)
	Comment 14 • 7 years ago

(In reply to Richard Maher from comment #13)
> WRT: - Mozilla documentation
> https://developer.mozilla.org/en-US/docs/Web/Manifest#Browser_compatibility 
> 
> After adding to homescreen, I am unable to lose any of the browser Chrome
> with Firefox on Android. (Samsung Galaxy S7)
> 
> Chrome and Opera are fine, Samsung browser degrades to supporting
> "standalone" but Firefox still has the URL, buttons and so on.

Maybe because of the config not exists yet?
Bug 1357091 - Need to provide default value when reading "manifest.install.enabled"

	Dale Harvey (:daleharvey)
	Comment 15 • 7 years ago

Even with the pref enabled we dont do anythingwith display: fullscreen, this isnt assigned to anyone as yet

	Richard Maher
	Comment 18 • 7 years ago

Does that mean this is in Nightly?

-- Excited from Perth

	Dale Harvey (:daleharvey)
	Comment 19 • 7 years ago

This is awesome, one issue is however is we need to ensure that we exit full screen once the user has navigated out of the scope of the app. The user trusts that the origin they have saved are not going to spoof them however we cant extend the same trust to any site the user navigates to after that. 

In http://searchfox.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/webapps/WebAppActivity.java#246 we are going to want to tear down any customisations inherited from the manifest once we are out of scope, the same for orientation likely (although thats less of a security risk)

	Dylan Roeh (:droeh) (he/him)
	Comment 22 • 7 years ago
mozreview-review

Comment on attachment 8895024 [details]
Bug 1126479 - Support fullscreen display mode for webapps on Android

https://reviewboard.mozilla.org/r/166154/#review172744

	(inactive) Jim Chen [:jchen] [:darchons]
	Comment 23 • 7 years ago
mozreview-review

Comment on attachment 8896028 [details]
Bug 1126479 - Correctly set widget size mode on Android

https://reviewboard.mozilla.org/r/167290/#review172882

	Pulsebot
	Comment 24 • 7 years ago

Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6798fd30a785
Correctly set widget size mode on Android r=jchen
https://hg.mozilla.org/integration/mozilla-inbound/rev/4fb119706335
Support fullscreen display mode for webapps on Android r=droeh

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 25 • 7 years ago

Backed out bug 1369817, bug 1369815, bug 1389269 and bug 1126479 for crashing in mochitest-chrome-3's layout/style/test/chrome/test_stylesheet_clone_import_rule.html on debug:

bug 1369817
https://hg.mozilla.org/integration/mozilla-inbound/rev/4af3a98934c427226e095246a098008bc3474ee7
https://hg.mozilla.org/integration/mozilla-inbound/rev/6bd81631bfad32fdc2fa46a8937d189caa21cb3d

bug 1369815
https://hg.mozilla.org/integration/mozilla-inbound/rev/7780a4af90284e7f812d44ec32adb68dcbcc94b1
https://hg.mozilla.org/integration/mozilla-inbound/rev/76f15802d69c2835eaa13e92df4bee34637f3b6c
https://hg.mozilla.org/integration/mozilla-inbound/rev/4871dc084c88feecdbabe1b3a9acdb5ffaa71a2b
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bbb1bd8335d0c49ac477e60e85a03029c8c6a17
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bc485e4ba834888fb7f5bbb97f9a91c33c1a485

bug 1389269
https://hg.mozilla.org/integration/mozilla-inbound/rev/78e49684354331b02d3e425d2afcd757559bd7db

bug 1126479
https://hg.mozilla.org/integration/mozilla-inbound/rev/bec2a9eac2d9c7ec52543e5b77a6ee38c3f6879f
https://hg.mozilla.org/integration/mozilla-inbound/rev/337a6416a05bc3a9fac980eaa54084b78cd639b6

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=4fb119706335b308f049949e5641565b035e4f80&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=123274657&repo=mozilla-inbound

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 26 • 7 years ago

So Try shows this is indeed from this patchset: https://treeherder.mozilla.org/#/jobs?repo=try&revision=06dc0a37528eddc566bf22c4db30090d2e24922c&selectedJob=123311402

	Pulsebot
	Comment 27 • 7 years ago

Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/26e3e0c51552
Correctly set widget size mode on Android r=jchen
https://hg.mozilla.org/integration/mozilla-inbound/rev/e938141097b5
Support fullscreen display mode for webapps on Android r=droeh

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 28 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/26e3e0c51552
https://hg.mozilla.org/mozilla-central/rev/e938141097b5

	Chris Mills [:cmills]
	Comment 29 • 7 years ago

I documented this by mentioning that the fullscreen is supported in 57 in the Browser compat table:

https://developer.mozilla.org/en-US/docs/Web/Manifest#Browser_compatibility

However, I'm a bit confused. Someone had already written in that minimal-ui and standalone are supported in 57 too. Can you check this, and let me know what the truth is here?

I also added a note into the Fx57 rel notes:

https://developer.mozilla.org/en-US/Firefox/Releases/57#Other

	Richard Maher
	Comment 30 • 7 years ago

Just updated Firefox 57 on my Android and this still does not work :-(

Try https://hypocampus.applications.uwa.edu.au/travelmanager.html

Not seeing my manifest? Not degrading to Fullscreen from Standalone?

	Dietrich Ayala (:dietrich)
	Comment 31 • 7 years ago

Hi Richard, thanks for reporting this! Can you file a new bug for this problem? Note the new bug # here in the comments, and I'll cc the right person to see why it's not working in this case.

	Richard Maher
	Comment 32 • 7 years ago

New bug has been filed: - https://bugzilla.mozilla.org/show_bug.cgi?id=1418701 Thanks