Closed Bug 1125987 Opened 9 years ago Closed 9 years ago

asking for review in a restricted bug doesn't work as expected ("You must provide a reviewer for review requests" instead of "That user cannot access that bug" error)

Categories

(bugzilla.mozilla.org :: General, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: keeler, Assigned: glob)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

STR:
* Add a patch to a restricted bug
* While doing so, ask for review from someone not in the groups the bug is restricted to (and not cc'd on the bug)

At this point, bugzilla complains that you haven't specified a reviewer.

* Finish attaching the patch without asking for review
* Click on "details" for the patch, attempt to ask for review

Now bugzilla will complain that that person isn't in the group or cc'd on the bug.

* Go back to the bug and manually cc the reviewer
* Go back to the details page and ask for review

Now bugzilla stops complaining.

I would expect this to work more like this:
* Add a patch to a restricted bug
* While doing so, ask for review. Bugzilla automatically cc's the person (like I believe it does with other bugs).
Assignee: nobody → glob
Summary: asking for review in a restricted bug doesn't work as expected → asking for review in a restricted bug doesn't work as expected ("You must provide a reviewer for review requests" instead of "That user cannot access that bug" error)
Attached patch 1125987_1.patchSplinter Review
- trigger the requestee checks to throw an error instead of silently dropping the requestee
Attachment #8579190 - Flags: review?(dylan)
Comment on attachment 8579190 [details] [diff] [review]
1125987_1.patch

Review of attachment 8579190 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

this is still less evil than monkey-patching ->can()...
Attachment #8579190 - Flags: review?(dylan) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   31e3b4e..9a07ea2  master -> master
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 1152458
No longer depends on: 1152458
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: