Closed Bug 1124982 Opened 9 years ago Closed 9 years ago

[AccessFu] ContentControl.adjustRange() is broken because of undefined 'content' symbol.

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox36 --- wontfix
firefox37 --- wontfix
firefox38 --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

Details

Attachments

(1 file)

Swiping up and down brings this:
I/Gecko   (11888): [AccessFuContent] ERROR Error handling message: {"action":"movePrevious","rule":"ListItem","origin":"parent","inputType":"gesture","adjustRange":true}:
I/Gecko   (11888):  content is not defined
I/Gecko   (11888):   cc_adjustRange@resource://gre/modules/accessibility/ContentControl.jsm:291:1
I/Gecko   (11888):   cc_handleMoveCursor@resource://gre/modules/accessibility/ContentControl.jsm:105:24
I/Gecko   (11888):   cc_receiveMessage@resource://gre/modules/accessibility/ContentControl.jsm:84:9
Comment on attachment 8554062 [details] [diff] [review]
[AccessFu] Use correct symbols for keycodes in ContentControl.adjustRange().

Looks good thanks!
Attachment #8554062 - Flags: review?(yzenevich) → review+
https://hg.mozilla.org/mozilla-central/rev/6ea9e86af28b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment on attachment 8554062 [details] [diff] [review]
[AccessFu] Use correct symbols for keycodes in ContentControl.adjustRange().

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Screen reader users won't be able to adjust custom slider widgets.
Testing completed: Yes, manual.
Risk to taking this patch (and alternatives if risky): Low, this bug fixes a serious syntax error.
String or UUID changes made by this patch: None.
Attachment #8554062 - Flags: approval-mozilla-b2g37?
Attachment #8554062 - Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
You need to log in before you can comment on or make changes to this bug.