Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Description • 9 years ago

The generic feedback form can capture remote-troubleshooting data and send it along with the feedback. The code in _handle_feedback_post checks to see if the user opted in and if so, does some work to capture the data and sends a statsd "optin" ping. If the user did not opt in, then it sends a statsd "optout" ping.

However, the code is overly broad. It should only be tracking optin/optout for the "Firefox" product and nothing else. What's going on now is that the Input dashboard shows a lot of optouts, but it shouldn't. It's hard to know what the "norm" should be so that we know when the site is "healthy".

This bug covers fixing that code.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 1 • 9 years ago

Making this a P1 and grabbing it. I need this to be working correctly soon. Having said that, it's release week so the earliest we can fix this is next week.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 2 • 9 years ago

In a PR: https://github.com/mozilla/fjord/pull/456

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 3 • 9 years ago

Landed in master: https://github.com/mozilla/fjord/commit/f75a94244595a00bbb4ee569e27e09afbbda42ff

Pushed this to production just now. Marking as FIXED.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 4 • 9 years ago

Marking this as 1 point retroactively.

Also, I got the wrong commit. It was this one:

https://github.com/mozilla/fjord/commit/60553bc5ff6f7aa7a58b06a6c7bae8ed4561ee8f