Anthony Ricaud (:rik) Reporter
	Description • 10 years ago

BugzillaJS currently embeds Try results in an iframe whenever someone includes a link to TBPL. It would be nice to have inline treeherder results too but it seems we cannot do it at the moment. See the Github issue with more details.

	Seth Fowler [:seth] [:s2h]
	Comment 1 • 10 years ago

FWIW, this issue is why I currently do not use Treeherder for Try results at all.

	Ed Morley [:emorley]
	Comment 2 • 9 years ago

There are two ways we could go about this:

1) Try something similar to what was done with TBPL: add additional URL params to hide UI elements to make it possible to just embed the whole Treeherder page in an iframe. We're not far from being able to do this actually - on the toolbar we already have a "collapse all revisions" option, we could add a URL param for that. The toolbars don't wrap brilliantly at a small screen width & I think the perf is worse than TBPL, but may work.

2) Create a standalone widget for embedding.

Either way, I think it's unlikely we'll have time to look at this bug before TBPL is end of lifed, since we have quite a backlog at the moment, and I think it's hard to justify prioritising an unofficial extension workflow, when Treeherder does have an API that third party tools could consume themselves (though in this case, I agree it makes sense to re-use Treeherder's UI components where possible).

That said, we'll happily accept patches if you have a chance to take a look at this yourselves in the meantime?

Source is at https://github.com/mozilla/treeherder-ui/

	Mauro Doglio [:mdoglio] Assignee
	Comment 3 • 9 years ago

I'm probably going to work on something like 2) this week for mozreview.

	Ed Morley [:emorley]
	Comment 4 • 9 years ago

Great :-)

	Mauro Doglio [:mdoglio] Assignee
	Comment 6 • 9 years ago

Attachment 8552664 [details] is a first attempt to provide such a widget. It's not as nice as the job count bar on treeherder-ui. Also, I haven't translated the job results to their more human-friendly counterpart. This is basically just a proof of concept, but it's still better than nothing I suppose :)

	Seth Fowler [:seth] [:s2h]
	Comment 8 • 9 years ago

Mauro, that looks excellent! Thank you for you taking this on!

There are two things I'd love to see added:

- I can't tell whether that summary tells you whether tests are still running. I may just be missing it, but if not, is it possible to indicate that somehow?

- I'd love to be able to view a list of the failures directly in the widget, so that I could click directly on each failure to bring it up in Treeherder and be able to view the log. Frequently there are many failures that are unrelated intermittent oranges and are irrelevant, so being able to see the list of failures directly in the widget would make it much easier to tell at a glance whether the patch needs more work or is ready to go.

	Mauro Doglio [:mdoglio] Assignee
	Comment 9 • 9 years ago

:seth pending and running will eventually show up, I was just unlucky when I picked that push as an example :-)
I think your second request is doable, but I would prefer to defer such a list to treeherder.
I could make each of those states a link to treeherder with only those jobs visible. Something like  https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=5e6e959f0043&filter-resultStatus=testfailed

	Seth Fowler [:seth] [:s2h]
	Comment 10 • 9 years ago

(In reply to Mauro Doglio [:mdoglio] from comment #9)
> :seth pending and running will eventually show up, I was just unlucky when I
> picked that push as an example :-)

Nice!

> I could make each of those states a link to treeherder with only those jobs
> visible.

That definitely sounds like it'd be very useful, whether we had the separate list of failures or not!

	Treeherder GitHub Bugbot
	Comment 11 • 9 years ago

Commits pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/b1881b26a1f2802a80d88a4263d506a7547e8bd1
Bug 1115904 - Add a widget showing a resultset status

https://github.com/mozilla/treeherder-service/commit/956c84e3e2d140da01369a7178d61acaac62d2d0
Merge pull request #342 from mozilla/bug-1115904

Bug 1115904 - Add a widget showing a resultset status

	Anthony Ricaud (:rik) Reporter
	Comment 12 • 9 years ago

From the commit, it seems we should point the iframe to https://treeherder.mozilla.org/resultset-status/<repository>/<revision>/. I haven't used treeherder though so I'm not sure what URL people will put in bugzilla comments. Anyone has an example?

	Ed Morley [:emorley]
	Comment 13 • 9 years ago

This is what the hghook outputs:
https://hg.mozilla.org/hgcustom/version-control-tools/file/default/hghooks/mozhghooks/push_printurls.py#l118

	Ed Morley [:emorley]
	Comment 14 • 9 years ago

I was looking for an example of this just now, so might as well paste it here:
https://treeherder.mozilla.org/embed/resultset-status/mozilla-central/cf1060d8ce9f/

(The URL in comment 12 is broken)