Prajjwal Singh Reporter
	Description • 10 years ago

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20141222004004

Steps to reproduce:

Not Applicable.


Actual results:

Not Applicable.


Expected results:

The share button in firefox does not currently have a keyboard shortcut(s) for easy access. It would be much faster and more convenient for a lot of people(say, vim users) if sharing was made possible using only the keyboard. Please consider adding this.

	desiradaniel2007
	Comment 1 • 10 years ago

Hi Prajjwal, do you any keyboard shortcut in mind? Also, what would you think of navigating between services using arrow keys? :)

	Prajjwal Singh Reporter
	Comment 2 • 10 years ago

(In reply to desiradaniel2007 from comment #1)
> Hi Prajjwal, do you any keyboard shortcut in mind? Also, what would you
> think of navigating between services using arrow keys? :)

A modifier plus any letter in the word "share" that isn't already a shortcut for something else would work. From looking at the keyboard shortcuts page for shortcuts of the form (ctrl|alt) + (s|h|a|r|e) that aren't already taken, I'd say the following are good candidates:

* <ctrl> + E
* <alt> + R

Just my opinion, though. Any shortcut would do, as long as it is documented.

I don't think navigating installed services with the arrow keys is a good idea, because people expect the arrow keys to move their cursor in the textarea by default. <alt> + (up|down) doesn't seem to do anything on my firefox. I think that would be the way to go.

	:Gijs (he/him)
	Comment 3 • 9 years ago

(In reply to Prajjwal Singh from comment #2)
> * <ctrl> + E

This focuses the search bar on Windows.

	Shane Caraveo (:mixedpuppy)
	Comment 4 • 9 years ago

Should this follow the lead of bug 1106932?

	Prajjwal Singh Reporter
	Comment 5 • 9 years ago

(In reply to Shane Caraveo (:mixedpuppy) from comment #4)
> Should this follow the lead of bug 1106932?

I think so, yes. That would be great...

	:Gijs (he/him)
	Comment 6 • 9 years ago

I think we should start with having a menu entry / submenus (for share providers that have their own buttons?) under [File]. Finding unused shortcuts is hard, so I think we should defer that for now.

Philipp, it would be great if you could look at this and clarify what should be done here so we can move forward. This kind of stuff is impacting keyboard/accessibility users and shouldn't be too hard to fix as long as we have ideas about how to do so.

	:Gijs (he/him)
	Comment 7 • 9 years ago

(In reply to :Gijs Kruitbosch from comment #6)
> I think we should start with having a menu entry / submenus (for share
> providers that have their own buttons?) under [File]. Finding unused
> shortcuts is hard, so I think we should defer that for now.
> 
> Philipp, it would be great if you could look at this and clarify what should
> be done here so we can move forward. This kind of stuff is impacting
> keyboard/accessibility users and shouldn't be too hard to fix as long as we
> have ideas about how to do so.

	(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo
	Comment 8 • 9 years ago

Adding Michael and Markus here...

As mentioned elsewhere, the share panel and our task continuity efforts partially solve the same problems. I'd like to have that untangled before proceeding. Whatever the result, keyboard accessibility should be a part of it.

	:Gijs (he/him)
	Comment 9 • 9 years ago

(In reply to Philipp Sackl [:phlsa] please use needinfo from comment #8)
> Adding Michael and Markus here...
> 
> As mentioned elsewhere, the share panel and our task continuity efforts
> partially solve the same problems. I'd like to have that untangled before
> proceeding. Whatever the result, keyboard accessibility should be a part of
> it.

What's the timeline for this? Can we just add a menuitem to open the panel in the meantime? That's relatively low-hanging fruit, and it would at least satisfy the baseline a11y requirements here.

	Shane Caraveo (:mixedpuppy)
	Comment 10 • 9 years ago

It would be nice to get this addressed in current versions, we have had a partner run into this and bring it up.

	(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo
	Comment 11 • 9 years ago

(In reply to :Gijs Kruitbosch from comment #9)
> (In reply to Philipp Sackl [:phlsa] please use needinfo from comment #8)
> > Adding Michael and Markus here...
> > 
> > As mentioned elsewhere, the share panel and our task continuity efforts
> > partially solve the same problems. I'd like to have that untangled before
> > proceeding. Whatever the result, keyboard accessibility should be a part of
> > it.
> 
> What's the timeline for this? Can we just add a menuitem to open the panel
> in the meantime? That's relatively low-hanging fruit, and it would at least
> satisfy the baseline a11y requirements here.

There actually is a (sort of) timeline now and it's »as soon as people get off of e10s or as soon as we hire«.

	BMO Automation
	Comment 12 • 5 years ago

SocialAPI was removed from Firefox 57 and is no longer available in any current release.