Justin Crawford [:hoosteeno] [:jcrawford] Reporter
	Description • 10 years ago

We'd like to replace MDN's feature request form[0] with a few new questions. The behavior of the form won't change much; the data it submits are pretty much the same. We just want to ask some different questions. They're in this google document:

https://docs.google.com/a/mozilla.com/document/d/1GjbbcYSdDQjnzZ_tgxyMW2b3dStAji9tAE872Os-1gM/edit#heading=h.68i8gok3utat

You can comment there (let me know if you need permission) with any questions, or put them below. 

[0] https://bugzilla.mozilla.org/enter_bug.cgi?product=Mozilla%20Developer%20Network#h=detail|feature

	David Lawrence [:dkl] Assignee
	Comment 1 • 10 years ago

Sorry for the delay with getting to this with the holidays and all. Will start on it now.

	Justin Crawford [:hoosteeno] [:jcrawford] Reporter
	Comment 2 • 10 years ago

Totally understand. Please let me know what else you need.

	David Lawrence [:dkl] Assignee
	Comment 3 • 9 years ago

Sorry again for the extra delay on this. I have performed the requested changes and put the new code on our test instance for your feedback here:

https://bugzilla-dev.allizom.org/form.mdn

To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   8dd1715..0759c1a  development -> development

Please try it and let me know if anything else needs changing.

dkl

	Justin Crawford [:hoosteeno] [:jcrawford] Reporter
	Comment 4 • 9 years ago

Thanks! 2 changes:

* We're not going to make a form for marketing requests, so you can remove this bullet from the top: "Requesting MDN assistance with developer marketing"

* When I fill out all the fields, I get a javascript alert indicating validation failed for fields that were previously but are no longer on the form. The alert says: 'Please enter some text for "What happened?"
Please enter some text for "What should have happened?"'

	David Lawrence [:dkl] Assignee
	Comment 5 • 9 years ago

(In reply to Justin Crawford [:hoosteeno] [:jcrawford] from comment #4)
> Thanks! 2 changes:
> 
> * We're not going to make a form for marketing requests, so you can remove
> this bullet from the top: "Requesting MDN assistance with developer
> marketing"

Removed

> * When I fill out all the fields, I get a javascript alert indicating
> validation failed for fields that were previously but are no longer on the
> form. The alert says: 'Please enter some text for "What happened?"
> Please enter some text for "What should have happened?"'

You found a bug for me in the old implementation that happens when you come from somewhere else with the bookmarked links such as 'form.mdn#h=detail|feature' which will load the feature based form but still thinks internally it is a 'bug' form. Did not happen if someone came to the form fresh and made a selection first.

Fixed properly now. Please give final feedback at:

https://bugzilla-dev.allizom.org/form.mdn

dkl

	Justin Crawford [:hoosteeno] [:jcrawford] Reporter
	Comment 6 • 9 years ago

:dkl, thanks!

Finally had a chance to dig in. One big bug is that, after submitting, the bug created does not include any of the data entered into form fields in the submission form.

	Justin Crawford [:hoosteeno] [:jcrawford] Reporter
	Comment 7 • 9 years ago

(In reply to Justin Crawford [:hoosteeno] [:jcrawford] from comment #6)
> :dkl, thanks!
> 
> Finally had a chance to dig in. One big bug is that, after submitting, the
> bug created does not include any of the data entered into form fields in the
> submission form.

For example: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1007677

	David Lawrence [:dkl] Assignee
	Comment 8 • 9 years ago

(In reply to Justin Crawford [:hoosteeno] [:jcrawford] from comment #6)
> :dkl, thanks!
> 
> Finally had a chance to dig in. One big bug is that, after submitting, the
> bug created does not include any of the data entered into form fields in the
> submission form.

Sorry bout that. Typo error that has been fixed once our test instance is updated to the latest code.

https://bugzilla-dev.allizom.org/form.mdn

dkl

	David Lawrence [:dkl] Assignee
	Comment 9 • 9 years ago

(In reply to David Lawrence [:dkl] from comment #8)
> (In reply to Justin Crawford [:hoosteeno] [:jcrawford] from comment #6)
> > :dkl, thanks!
> > 
> > Finally had a chance to dig in. One big bug is that, after submitting, the
> > bug created does not include any of the data entered into form fields in the
> > submission form.
> 
> Sorry bout that. Typo error that has been fixed once our test instance is
> updated to the latest code.
> 
> https://bugzilla-dev.allizom.org/form.mdn
> 
> dkl

Ping for feedback.

dkl

	Justin Crawford [:hoosteeno] [:jcrawford] Reporter
	Comment 10 • 9 years ago

dkl, thanks for the ping!

One more bug: When I choose any of the radio buttons besides "Other", the output in the summary box is "All visitors to MDN". For example, I chose "Staff" for this bug: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1008208

	David Lawrence [:dkl] Assignee
	Comment 11 • 9 years ago

(In reply to Justin Crawford [:hoosteeno] [:jcrawford] from comment #10)
> dkl, thanks for the ping!
> 
> One more bug: When I choose any of the radio buttons besides "Other", the
> output in the summary box is "All visitors to MDN". For example, I chose
> "Staff" for this bug:
> https://bugzilla-dev.allizom.org/show_bug.cgi?id=1008208

Thanks for finding that issue. New version pushed out for final testing.

https://bugzilla-dev.allizom.org/form.mdn
 
dkl

	Mark Côté [:mcote]
	Comment 12 • 9 years ago

Just checking in.  Is the form good now?

	David Lawrence [:dkl] Assignee
	Comment 13 • 9 years ago

Ping hoosteeno@mozilla.com

	Justin Crawford [:hoosteeno] [:jcrawford] Reporter
	Comment 14 • 9 years ago

Sorry -- was away for a while.

This looks good to me. Thanks for the fixes!

	David Lawrence [:dkl] Assignee
	Comment 15 • 9 years ago

Thanks

To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   4fbbdbc..c4975b6  master -> master

Should be in the next code push which will be early next week.

dkl