Closed
Bug 1113171
Opened 10 years ago
Closed 9 years ago
upgrade requests to 2.5.1
Categories
(Input Graveyard :: Code Quality, defect)
Input Graveyard
Code Quality
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: willkg)
Details
(Whiteboard: u=dev c=codequality p=1 s=input.2015q1)
Currently requests is pinned to 1.1 in requirements/requirements.txt. This bug covers: 1. figuring out why we're pinned to that version (restrictions of another dependency?) 2. figure out how to upgrade requests to something modern
Updated•9 years ago
|
Flags: needinfo?(willkg)
Assignee | ||
Comment 1•9 years ago
|
||
I'm not sure why I got needinfo'd on this bug.
Comment 2•9 years ago
|
||
This is the first time when I am working on porting a python package to upgraded version. So, just wanted to know that how it works and what's the procedure to do porting.
Assignee | ||
Comment 3•9 years ago
|
||
Ok--now I understand why you flagged me for info. This isn't a bug that's good for new contributors, so I don't think it's something you should work on.
Flags: needinfo?(willkg)
Comment 4•9 years ago
|
||
Can you help me in choosing a bug on which I should work on ?
Assignee | ||
Comment 5•9 years ago
|
||
You should ask questions like that either on IRC or on the input-dev mailing list. Links to those as well as the link to the list of mentored bugs are all in the docs: http://fjord.readthedocs.org/en/latest/welcome.html
Assignee | ||
Comment 6•9 years ago
|
||
I don't see anything in vendor/ that requires requests <= 1.1. I think ok to update it. Let's update it to the most recent version: 2.5.1
Summary: upgrade requests to something modern → upgrade requests to 2.5.1
Whiteboard: u=dev c=codequality p= s=input.2015q1
Assignee | ||
Comment 7•9 years ago
|
||
In a PR: https://github.com/mozilla/fjord/pull/466
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Whiteboard: u=dev c=codequality p= s=input.2015q1 → u=dev c=codequality p=1 s=input.2015q1
Assignee | ||
Comment 8•9 years ago
|
||
Landed in master: https://github.com/mozilla/fjord/commit/15b19b295977ffbc48449f3985121812508440c8 https://github.com/mozilla/fjord/commit/83079bffb32d635375d1500af8cbe442cce04a34 Will push on Monday.
Assignee | ||
Comment 9•9 years ago
|
||
Pushed this to production just now. Marking as FIXED.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•