Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Description • 10 years ago

I checked this morning and noticed a bunch of RemoteTroubleshootingInfo records with a data value of {}.

We shouldn't be saving empty data to the db.

This bug covers fixing that and either writing a test for it or figuring out why the existing test isn't working.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 1 • 10 years ago

Oops--that should be ResponseTroubleshootingInfo records.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 2 • 10 years ago

In a PR: https://github.com/mozilla/fjord/pull/418

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 3 • 10 years ago

Landed in master:

https://github.com/mozilla/fjord/commit/6f24ce77db1e75ff89068394003ee1c23fe79bef
https://github.com/mozilla/fjord/commit/aac733b7ad9cf4aacfaa5a00d7f9c7b9c994e634

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 4 • 10 years ago

Pushed to prod just now.

Need to wait until I see an optin ping before I close this as FIXED.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 5 • 10 years ago

Added a "yes--we have browser data" indicator to response view. In a PR: https://github.com/mozilla/fjord/pull/419

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 6 • 10 years ago

Landed in master: https://github.com/mozilla/fjord/commit/278095d5d5684c9d78e7c93f14fa15ecd4a7bfd3

Verified it works and that my test feedback earlier did have browser data. My dashboard needs fixing. :(

Marking as FIXED.