Closed
Bug 1112084
Opened 9 years ago
Closed 9 years ago
create requirements/dev.txt
Categories
(Input Graveyard :: Code Quality, defect)
Input Graveyard
Code Quality
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: lgp171188, Mentored)
Details
(Whiteboard: u=dev c=codequality p= s=input.2014q4)
In bug #1075563, I waffled about whether to have flake8 in its own requirements file and instead decided to just add it to the docs. However, we have different needs now. It makes sense to have a dev requirements file for flake8 and other dev libraries. This bug covers: 1. creating a requirements/dev.txt file 2. adding "pip install requirements/dev.txt" to the vagrant provisioning script (pip--not peep) 3. updating the documentation regarding flake8 and pre commit hooks
Reporter | ||
Updated•9 years ago
|
Mentor: willkg
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → lgp171188
Reporter | ||
Comment 1•9 years ago
|
||
In a PR: https://github.com/mozilla/fjord/pull/417 Landed in master: https://github.com/mozilla/fjord/commit/d4c5a0926122042f153339b8e62940fb1b443ff8 https://github.com/mozilla/fjord/commit/4f03c4880159552d58980f6a23ad48e70619ad9b https://github.com/mozilla/fjord/commit/03c5710485e77a719c6754be1d9a04c94c8f174a This doesn't need to be deployed since it's dev-environment-specific. Marking as FIXED. Thank you!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•