Andreas Tolfsen ❲:ato❳ Reporter
	Description • 10 years ago

After the introduction of MarionetteServerConnection.setSessionCapabilities (internal method) we should consider making the sessionCapabilities member immutable, or in JS vernacular, “frozen”:

    this.sessionCapabilities = Object.freeze(caps);

This would affect the this.sessionCapabiltiies.B2G = true workaround we have in getSessionCapabilities, but the way that is currently coded can easily be considered a bug.

Doing this will force anyone interacting with the capabilities to go through setSessionCapabilities, which as far as I understand would be desired as there are more changes to come to the specification in this area.

	David Burns :automatedtester
	Comment 1 • 10 years ago

Need info for?

	Andreas Tolfsen ❲:ato❳ Reporter
	Comment 2 • 10 years ago

Since you've done the work on session capabilities I'd like to hear your input on whether this is a good idea or not.  I don't fully understand the implementation in setSessionCapabilities and what it aims to achieve.

	David Burns :automatedtester
	Comment 3 • 10 years ago

Session Capabilities are the equivalent to WebDriver's desired capabilities. Currently when newSession is called it calls setSessionCapabilites that updates a common object that everything should have access to if they need to check anything in there.

I am happy to make it immutable but since nothing from the client side can access this I don't see it being a high priority at the moment.

	Andreas Tolfsen ❲:ato❳ Reporter
	Comment 4 • 10 years ago

Thanks.  Yes, it would purely be an internal security measure.

	David Burns :automatedtester
	Comment 5 • 7 years ago

is this still required with the work done around session.js?

	Andreas Tolfsen ❲:ato❳ Reporter
	Comment 6 • 7 years ago

Not required I don’t think.