Andreas Tolfsen ❲:ato❳ Assignee
	Description • 10 years ago

marionette-server.js has four incorrect references to nsITimer.TYPE_ONE_SHOT that trigger ReferenceError's at runtime.

The affected code only works by chance that the constant TYPE_ONE_SHOT's value is 0.

Affected lines as of 219503:f14dcd1c8c0b:

% g ONESHOT
./marionette-server.js:892:       }, inactivityTimeout, Ci.nsITimer.TYPE_ONESHOT);
./marionette-server.js:1055:      }, inactivityTimeout, Ci.nsITimer.TYPE_ONESHOT);
./marionette-server.js:1063:       }, inactivityTimeout, Ci.nsITimer.TYPE_ONESHOT);
./marionette-server.js:1131:        }, that.timeout, Ci.nsITimer.TYPE_ONESHOT);

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 2 • 10 years ago

/r/1453 - Bug 1111260 - Fix references to nsITimer.TYPE_ONE_SHOT; r=dburns

Pull down this commit:

hg pull review -r f6174b2e3740a0cb17fae802aad22ccbc7234638

	David Burns :automatedtester
	Comment 3 • 10 years ago

https://reviewboard.mozilla.org/r/1451/#review905

Ship It!

	Andreas Tolfsen ❲:ato❳ Assignee
	Comment 4 • 10 years ago

try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=32ab544a43e1

	Ryan VanderMeulen [:RyanVM]
	Comment 5 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/13d74279980e

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/13d74279980e