Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Description • 10 years ago

Over the weekend in a sleep-deprived haze, I "fixed" the HB data view pager and then inverted the sort order.

This bug covers fixing some issues that created and making the view generally more helpful:

1. fix "newer"/"older" link text
2. add a "sort by updated_ts/-updated_ts"
3. add "search" which would do a case-insensitive search in some fields
4. increase page size


Possibly more nits to fix in further comments. Plus we should fix easy ones first and hard ones when we have a chance.

	Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )
	Comment 1 • 10 years ago

1.  Newer / older

"Change sort order" sounds very terse
Half-fixes are often a curse
I dont mean to be rude
but time has come all unglued!
the newer/older labels need to be reversed


2.  (I don't actually need sort reverse)

3.  Search:


I wish a design to erect
to allow more nuanced "select"
but I don't want to ask
and increase your task
it has lots of side effects

One nice well-intentioned note
That I don't quite know how to emote
don't mean to whine
Django orm operator style is fine
to filter to records with votes

(i.e., rating>=0  rating==8   or (in json:  thing.subthing=="a"

or tokenized:   field[OP][val], all in quote?  break it up `shlex` style? 

4. 

There was an old analyst
who once to be a quiz show panelist
who thought once or twice
"more results would be nice"
to help him understand all this



5.  'first' last can be nice too.  I tend to like  
  - [newer] page x of y [older] [1] [y]  rather than   
  - [1][newer] x of y [older][y]

(even though the first is more 'logical'

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 2 • 10 years ago

Fixed item 1 (newer/older) and item 5 (first/last) in https://github.com/mozilla/fjord/commit/d9e8ffdd31196202594f9004cc53010324ad66ad

Fixed item 2 (sortby updated_ts) in https://github.com/mozilla/fjord/commit/00e8628975affe9face2110aef047e23b49e4439

Changed the display of timestamps so it's readable. Hovering over the displays shows original timestamp values. We didn't talk about this one, but it seemed like it'd be helpful.

Fixed item 4 (change paging from 25/page to 100/page) in https://github.com/mozilla/fjord/commit/17b908ae16a157ffdd397bebe81e4805330c24f6

Will push those changes to prod next time I deploy.


I'll have to think about searching. That's a tough nut.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 3 • 10 years ago

All the fixes in comment #2 were pushed to production just now.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 4 • 10 years ago

Bumping this to 2015q1 because we're out of time for this quarter.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 5 • 9 years ago

The outstanding thing here is this one:

> 3.  Search:
> 
> 
> I wish a design to erect
> to allow more nuanced "select"
> but I don't want to ask
> and increase your task
> it has lots of side effects
> 
> One nice well-intentioned note
> That I don't quite know how to emote
> don't mean to whine
> Django orm operator style is fine
> to filter to records with votes
> 
> (i.e., rating>=0  rating==8   or (in json:  thing.subthing=="a"
> 
> or tokenized:   field[OP][val], all in quote?  break it up `shlex` style? 

I don't know how to do that offhand since mysql doesn't know anything about JSON blobs. If we were allowed to index everything in ES, then we could do this with ES, but we're not, so we can't. I don't know what other options there are.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 6 • 9 years ago

I created bug #1127129 for that outstanding search piece. I'm going to mark this as FIXED.