Trevor Saunders (:tbsaunde) Assignee
	Description • 10 years ago

another case of adding an appropriate method to ProxyAccessible / PDocAccessible and calling it from refChildAtCB.  Cribbing from bugs like 1088477 should be straight forward.

	David Burns :automatedtester
	Comment 1 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/c197752ff132

	Liz Henry (:lizzard) (relman/hg->git project)
	Comment 2 • 9 years ago

https://hg.mozilla.org/projects/holly/rev/e16d14a4f54d

	Trevor Saunders (:tbsaunde) Assignee
	Comment 5 • 9 years ago

OuterDocAccessibles can be the container for a remote top level document.  We
  sometimes need to get the child for these OuterDocAccessible's which means
  the child is a proxy while the original object was an actual Accessible.
  This means we need to add a different function instead of making ChildAt() do
  the right thing.

	Lorien Hu (:lsocks)
	Comment 8 • 9 years ago

Comment on attachment 8616663 [details] [diff] [review]
Add OuterDocAccessible::RemoteChildDoc()

Review of attachment 8616663 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/generic/OuterDocAccessible.cpp
@@ +193,5 @@
> +    return nullptr;
> +
> +  const nsTArray<PDocAccessibleParent*>& docs = tab->ManagedPDocAccessibleParent();
> +  size_t docCount = docs.Length();
> +  for (size_t i = 0; i < docCount; i++) {

XXX Add comment: Manage non-top level PDocAccessibles with parent actor

::: accessible/generic/OuterDocAccessible.h
@@ +27,5 @@
>    OuterDocAccessible(nsIContent* aContent, DocAccessible* aDoc);
>  
>    NS_DECL_ISUPPORTS_INHERITED
>  
> +    ProxyAccessible* RemoteChildDoc() const;

nit: Remove two extra spaces from the start

	Lorien Hu (:lsocks)
	Comment 9 • 9 years ago

Comment on attachment 8616762 [details] [diff] [review]
implement ProxyAccessible::EmbeddedChildAt

Review of attachment 8616762 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/ipc/PDocAccessible.ipdl
@@ +217,5 @@
>  
>    prio(high) sync TakeFocus(uint64_t aID);
>    prio(high) sync IndexOfEmbeddedChild(uint64_t aID, uint64_t aChildID)
>      returns(uint32_t childIdx);
> +     prio(high) sync EmbeddedChildAt(uint64_t aID, uint32_t aChildIdx)

nit: leading whitespace

	Lorien Hu (:lsocks)
	Comment 10 • 9 years ago

Comment on attachment 8616763 [details] [diff] [review]
Teach refChildCB deal with proxies

Review of attachment 8616763 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/atk/AccessibleWrap.cpp
@@ +863,1 @@
>  

Add else return nullptr here

	Pulsebot
	Comment 11 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/4013640cfeea
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8f6d1500adb
https://hg.mozilla.org/integration/mozilla-inbound/rev/4670d8b5090e
https://hg.mozilla.org/integration/mozilla-inbound/rev/84dd29ab2ac6

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 12 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/4013640cfeea
https://hg.mozilla.org/mozilla-central/rev/e8f6d1500adb
https://hg.mozilla.org/mozilla-central/rev/4670d8b5090e
https://hg.mozilla.org/mozilla-central/rev/84dd29ab2ac6