Closed
Bug 1107083
Opened 10 years ago
Closed 10 years ago
feedback not getting versions
Categories
(Input Graveyard :: Submission, defect, P1)
Input Graveyard
Submission
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: willkg)
Details
(Whiteboard: u=user c=feedback p=1 s=input.2014q4)
Some feedback is coming in and it's not getting assigned a version. For example: https://input.mozilla.org/en-US/dashboard/response/4736014 That has no version, but it does have a user agent which should match the product and thus it should pick up a version. My wild guess is that the user agent inference code isn't capturing versions right. This bug covers gathering a few more feedback examples of the problem, investigating the issue and fixing it.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
Cheng provided this search which picks up a bunch: https://input.mozilla.org/en-US/analytics/search?product=Firefox&version=&date_start=2014-11-24&date_end=2014-12-03 It's like 1/4 of feedback in that period.
Assignee | ||
Comment 2•10 years ago
|
||
Did some poking around and I spent some quality time with the inference code. I rewrote bits of it to read better which makes it easier to reason about and added some tests. In a PR: https://github.com/mozilla/fjord/pull/403
Whiteboard: u=user c=feedback p= s=input.2014q4 → u=user c=feedback p=1 s=input.2014q4
Assignee | ||
Comment 3•10 years ago
|
||
This doesn't yet include a backfill migration. I'm going to wait on that until I land this and make sure it's working right.
Assignee | ||
Comment 4•10 years ago
|
||
Landed in https://github.com/mozilla/fjord/commit/808fa832c186686b3e5e56a47b2dce97e4cae856 Pushed to prod just now. Will keep an eye on the new code for a bit and if it's good then I'll write a data migration to backfill.
Assignee | ||
Comment 5•10 years ago
|
||
This looks fixed. Haven't seen another instance of this in an hour. Writing the backfill data migration now.
Assignee | ||
Comment 6•10 years ago
|
||
PR with backfill migration: https://github.com/mozilla/fjord/pull/404
Assignee | ||
Comment 7•10 years ago
|
||
Backfill data migration landed in https://github.com/mozilla/fjord/commit/39dc9437e948a4d91827114018eef903c69016ea Pushed to production which backfilled things. Then I reindexed so it's updated in the index. The number of "unknown" version responses dropped to about 170. Marking as FIXED.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•