Boris Zbarsky [:bzbarsky] Reporter
	Description • 10 years ago

See bug 1101123 comment 3.

The most plausible solution for this is probably to make the sandbox global involved a proxy, fixing whatever issues block proxies as globals...

Or is there a different long-term plan for this stuff?  Bill?

	Boris Zbarsky [:bzbarsky] Reporter
	Comment 1 • 10 years ago

Once this is fixed, JSPROP_REDEFINE_NONCONFIGURABLE needs to go away.

	Bill McCloskey [inactive unless it's an emergency] (:billm)
	Comment 2 • 10 years ago

I guess allowing proxy globals is the long term plan, yes.

	André Bargull [:anba] Assignee
	Comment 3 • 6 years ago

bug 1445551 removed the sandbox code which used JSPROP_REDEFINE_NONCONFIGURABLE, so the skip-redefine-check hack in js::NativeDefineProperty can now be removed, too. \o/

https://searchfox.org/mozilla-central/search?q=JSPROP_REDEFINE_NONCONFIGURABLE&case=true&path=

	André Bargull [:anba] Assignee
	Comment 5 • 6 years ago

Rebased to apply cleanly on inbound, carrying r+.

	André Bargull [:anba] Assignee
	Comment 6 • 6 years ago

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=75c55845c8e80993c58cc38106a720a57bbcf3b6

	Pulsebot
	Comment 7 • 6 years ago

Pushed by rgurzau@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d498636e0d5
Remove JSPROP_REDEFINE_NONCONFIGURABLE from jsapi. r=jorendorff

	Cristina Coroiu [:ccoroiu]
	Comment 8 • 6 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/1d498636e0d5