Closed
Bug 1103956
Opened 10 years ago
Closed 10 years ago
Remove explicit type checking from Wait class
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: davehunt, Assigned: davehunt)
References
Details
Attachments
(1 file)
973 bytes,
patch
|
ato
:
review+
|
Details | Diff | Splinter Review |
The Wait class currently waits until the condition explicitly returns a False boolean value. As discussed in bug 1097032 we should change this to simply check for a falsy value.
Assignee | ||
Comment 1•10 years ago
|
||
Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5f9742f26d40
Comment 2•10 years ago
|
||
Comment on attachment 8527649 [details] [diff] [review] Remove explicit type check in Wait class. v1.0 Review of attachment 8527649 [details] [diff] [review]: ----------------------------------------------------------------- Results from try look surprisingly good! Crossing my fingers this will work. (-:
Attachment #8527649 -
Flags: review?(ato) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1dca3cd59b4
Keywords: checkin-needed
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a1dca3cd59b4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•