Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Description • 10 years ago

We need an HB view for surveys like the addproducts view. This way, analyzers can create new surveys, enable/disable surveys and see which survey names are valid.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 1 • 10 years ago

The totally basic immediate need of viewing surveys is in PR: https://github.com/mozilla/fjord/pull/392

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 2 • 10 years ago

Landed in https://github.com/mozilla/fjord/commit/0996148e3b7f47722cd07682a9948e36cf2b5970

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 3 • 10 years ago

That only shows the existing surveys. I didn't go the whole 9 yards to allow for creating new surveys and editing them. I'm pushing that work off until later when things aren't so crazy.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 4 • 10 years ago

Pushed the basic view to production just now.

Will keep this open to finish up the work later.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 5 • 10 years ago

Sliding this into Adam's pile.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 6 • 10 years ago

Oopos--unassigning myself.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 7 • 9 years ago

Tossing this in the 2015q1 queue.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 8 • 9 years ago

Bumping this to P3 since it's not super important to get done.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 9 • 9 years ago

Talked to lguruprasad about this on IRC. Assigning it to him.

The summary of our conversation goes like this:

* I threw the existing heartbeat survey view together just so we had something Gregg could use, but it's missing a lot of stuff.

* I don't have a preference of sticking with function based views or switching to class based views--whichever works best is fine by me.

* The code should remain part of the analytics app since that's where all the other view code for Input for analyzers lives. That might seem a little odd, but it makes some things easier to deal with.

* The view needs to allow members of the analyzers group the ability to view, create and update heartbeat surveys.

* The users for this consist of Gregg and me and whichever other User Advocacy people end up getting involved with heartbeat. Having said that, we have a need for similar things in other areas of Input and if we had a good system for this, we could use that to build/improve the other things. For example, product maintenance.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 10 • 9 years ago

In a PR: https://github.com/mozilla/fjord/pull/490

Landed in master: https://github.com/mozilla/fjord/commit/73eaaf28d7c562e3ff0ee3aadf88b8a71f722294

That covers the "create survey" form and also reworks it to use a CBV.

I'll push it to production later.

The last bit that needs to be implemented is the ability to update/change existing surveys.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 11 • 9 years ago

Pushed the "create survey" bits to prod just now.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 12 • 9 years ago

Update survey form PR: https://github.com/mozilla/fjord/pull/504

Landed in master: https://github.com/mozilla/fjord/commit/3668585a294dfe960117008bbb68f76d297dd059

I'll push that out in the next deploy.

	Will Kahn-Greene [:willkg] ET needinfo? me Reporter
	Comment 13 • 9 years ago

Pushed it to production just now. Marking as FIXED.

Thank you!