Closed Bug 1100124 Opened 10 years ago Closed 9 years ago

Add --jsdebugger flag to mach marionette-test

Categories

(Remote Protocol :: Marionette, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla37

People

(Reporter: ato, Assigned: chmanchester)

References

Details

(Keywords: pi-marionette-runner, pi-marionette-server)

Attachments

(1 file, 1 obsolete file)

Add the --jsdebugger flag to mach marionette-test similar to what mochitest does, so that chrome debugger can be opened on start.
Relevant files to look at:

testing/mochitest/mach_commands.py:193:        jsdebugger=False, debug_on_failure=False, start_at=None, end_at=None,
testing/mochitest/runtests.py:1801:      if options.jsdebugger:
testing/mochitest/browser-harness.xul:315:  <button id="runTestsButton" oncommand="runTests();" label="Run All Tests"/>
would this be better to load the browser toolbox and connect to the browser?
This would allow the toolbox to be opened on starting Firefox so that debugger; statements could be respected.  It would especially be useful when debugging automated test cases, such as Mn tests.
/r/1531 - Bug 1100124 - Add --jsdebugger to run marionette under the jsdebugger.

Pull down this commit:

hg pull review -r 90fa12366b70cfce299f13b9f3b820baddff72d9
Comment on attachment 8537612 [details]
MozReview Request: bz://1100124/chmanchester

This is working pretty well, and does something like mochitest browser tests. Run "./mach marionette-test --jsdebugger", wait a bit for the toolbox to load, click the notification box, and as marionette runs tests the jsdebugger will pause on "debugger;" statements in marionette's js. ato, does this seem like what you had in mind?
Attachment #8537612 - Flags: feedback?(ato)
Attachment #8537612 - Flags: review+
https://reviewboard.mozilla.org/r/1529/#review935

This is exactly what I had in mind, and it makes it a world easier to debug the Marionette server.  I tried it out and it works perfectly.
Attachment #8537612 - Flags: feedback?(ato) → feedback+
https://hg.mozilla.org/mozilla-central/rev/804024438f49
Assignee: nobody → cmanchester
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Attachment #8537612 - Attachment is obsolete: true
Attachment #8618645 - Flags: review+
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: