Dustin J. Mitchell [:dustin] (he/him) Reporter
	Description • 10 years ago

Jake tells me this is in a GPO now, but it's not in puppet.  So, port the GPO to puppet.

	Dustin J. Mitchell [:dustin] (he/him) Reporter
	Comment 1 • 10 years ago

https://github.com/dividehex/metric-collective

	Amy Rich [:arr] [:arich]
	Comment 2 • 9 years ago

markco, do you know if this is already taken care of? If not, dividehex, is it easy to do?

	Mark Cornmesser [:markco] OOO 2024/04/15
	Comment 3 • 9 years ago

No it has not been done yet.

	Jake Watkins [:dividehex] Assignee
	Comment 4 • 9 years ago

Q had a good suggestion of packaging metcollective up as an exe to eliminate the problem of psutil and pywin32 being dependencies.  He also said there is a wrapper script to handle registering as a service.

	Jake Watkins [:dividehex] Assignee
	Comment 5 • 9 years ago

The options for bundling metcollect up into an exe came down to py2exe and pyinstaller.  I really wanted to get pyinstaller to work but it just wasn't going to happen.  It compiled nicely and even installed as a windows service properly but it just wouldn't start the service.  py2exe on the other hand worked although the setup.py must be configured so py2exe can properly handle the pywin32 service utility code.

A couple gotchas I ran into included __file__ being different between compiled vs non-compiled.  sys.argv[0] provided a replacement without needing to detect which state it was run from.  Also, required some dll exclusions to properly compile.

I also updated the metric collective code base to handle the latest psutil (3.0.1).

The exe under /data/repos/EXEs was compiled with: psutil-3.0.1.win32, pywin32-219.win32-py2.7, python-2.7.10, py2exe-0.6.9.win32-py2.7 and was built against mettric collective commit 2f05b79690c2c0fa1dc839cca5ad8b4d8179214b

Instructions for rebuilding the bundled exe are in the README.md

	Jake Watkins [:dividehex] Assignee
	Comment 6 • 9 years ago

This patch handles installing the bundled metcollect.exe and registers it as a service.  It also set the graphite host using the same config parameters used by collectd.

The service registration exec is fairly idempotent and will update current windows hosts running the gpo installed metcollect to point to the new version.  This means it would be safe to disable/delete the current gpo and deploy this when the time comes.

Also note, this is just the module and *NOT* being deployed by any toplevel manifests yet.

	Jake Watkins [:dividehex] Assignee
	Comment 7 • 9 years ago

Comment on attachment 8631924 [details] [diff] [review]
bug1097356-1.patch

Tested on 2008 ec2 instance and on a 2008 ix system

	Dustin J. Mitchell [:dustin] (he/him) Reporter
	Comment 8 • 9 years ago

Comment on attachment 8631924 [details] [diff] [review]
bug1097356-1.patch

Review of attachment 8631924 [details] [diff] [review]:
-----------------------------------------------------------------

Is the process of building metcollect.exe in version control somewhere?

	Jake Watkins [:dividehex] Assignee
	Comment 9 • 9 years ago

(In reply to Dustin J. Mitchell [:dustin] from comment #8)
> Comment on attachment 8631924 [details] [diff] [review]
> bug1097356-1.patch
> 
> Review of attachment 8631924 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Is the process of building metcollect.exe in version control somewhere?

Yes, see github README.md
https://github.com/dividehex/metric-collective/

	Jake Watkins [:dividehex] Assignee
	Comment 10 • 9 years ago

Comment on attachment 8631924 [details] [diff] [review]
bug1097356-1.patch

remote:   https://hg.mozilla.org/build/puppet/rev/f44c57514c19
remote:   https://hg.mozilla.org/build/puppet/rev/b9c93fdeaec8

	Jake Watkins [:dividehex] Assignee
	Comment 11 • 9 years ago

simply enables metcollect module for windows

	Jake Watkins [:dividehex] Assignee
	Comment 12 • 9 years ago

Comment on attachment 8638164 [details] [diff] [review]
bug1097345-1.patch

remote:   https://hg.mozilla.org/build/puppet/rev/8488b7282499
remote:   https://hg.mozilla.org/build/puppet/rev/a4c566b8b3fc

	Jake Watkins [:dividehex] Assignee
	Comment 13 • 9 years ago

Comment on attachment 8638164 [details] [diff] [review]
bug1097345-1.patch

whoops! this was the wrong patch :-(

	Jake Watkins [:dividehex] Assignee
	Comment 14 • 9 years ago

This is the correct patch and has already been checked in