Closed
Bug 1094197
Opened 10 years ago
Closed 10 years ago
fix JSONObjectField to have a default default of u'{}'
Categories
(Input Graveyard :: Code Quality, defect)
Input Graveyard
Code Quality
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: willkg)
Details
(Whiteboard: u=dev c=codequality p=1 s=input.2014q4)
Right now, whenever I use a JSONObjectField in a data model, I have to do this: foo = JSONObjectField(default=u'{}') That default should be the default default. The code for JSONObjectField is at fjord/base/models.py . This bug covers: 1. fixing the JSONObjectField so that the default defaults to u'{}' 2. go through the models.py files and remove the extra text
Assignee | ||
Comment 1•10 years ago
|
||
Grabbing this to fix now since it's annoying. It's an easy fix.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Whiteboard: u=dev c=codequality p=1 s=input.2014q4
Assignee | ||
Comment 2•10 years ago
|
||
In a PR: https://github.com/mozilla/fjord/pull/376
Assignee | ||
Comment 3•10 years ago
|
||
Landed in master: https://github.com/mozilla/fjord/commit/f233aabdfe4d28ac007d05e6deb85818c5e8a291 I'll push it later.
Assignee | ||
Comment 4•10 years ago
|
||
Pushed this to prod just now.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•