Closed
Bug 1093222
Opened 10 years ago
Closed 9 years ago
ditch django-cache-machine
Categories
(Input Graveyard :: Backend, defect)
Input Graveyard
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
2015q1
People
(Reporter: willkg, Assigned: rrosario)
References
Details
(Whiteboard: u=dev c=codequality p=1 s=input.2015q1)
django-cache-machine is poorly maintained in the sense that they never put out releases and doing the sorts of things maintainers should be doing for a properly maintained project. Ricky pointed out that Input probably doesn't need django-cache-machine at all. Most of the "fetch" kinds of things pull from ES and not the db. We could easily write a mini-caching layer for the few things that pull from the db that actually need to be cached. This bug covers researching removing django-cache-machine and examining whether it will create performance issues if we do.
Reporter | ||
Comment 1•10 years ago
|
||
Jannis said they ditched it on MDN and haven't been happier. I think that suggests we should just ditch it and then fix performance issues as they come up.
Reporter | ||
Updated•10 years ago
|
Whiteboard: u=dev c=codequality p= s=input.2015q1
Reporter | ||
Updated•10 years ago
|
Whiteboard: u=dev c=codequality p= s=input.2015q1 → u=dev c=codequality p= s=input.adam
Reporter | ||
Comment 2•9 years ago
|
||
Tossing this in the 2015q1 queue.
Whiteboard: u=dev c=codequality p= s=input.adam → u=dev c=codequality p= s=input.2015q1
Reporter | ||
Comment 3•9 years ago
|
||
Might as well ditch this before the Django upgrade to simplify things.
Blocks: 1118765
Assignee | ||
Comment 4•9 years ago
|
||
Gonna work on this todayish.
Assignee: nobody → rrosario
Target Milestone: --- → 2015q1
Assignee | ||
Comment 5•9 years ago
|
||
The pull request was here: https://github.com/mozilla/fjord/pull/433 The commits that landed on master: https://github.com/mozilla/fjord/commit/565e05d060fa8dffb896982502815405f9fdae8f https://github.com/mozilla/fjord/commit/53d8043e12b57658417cdc4e15e3de1896ce2ce4 https://github.com/mozilla/fjord/commit/0a47fdc0dd8cd27c2d125dc2480aff1bb4a11f31
Assignee | ||
Comment 6•9 years ago
|
||
I think this was about 1pt.
Whiteboard: u=dev c=codequality p= s=input.2015q1 → u=dev c=codequality p=1 s=input.2015q1
Assignee | ||
Comment 7•9 years ago
|
||
willkg just deployed to prod.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•