Closed Bug 1091716 Opened 10 years ago Closed 9 years ago

fix url validation in generic form to handle about:config type urls

Categories

(Input Graveyard :: Submission, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: lgp171188, Mentored)

Details

(Whiteboard: u=user c=feedback p= s=input.2015q1)

+++ This bug was initially created as a clone of Bug #1057617 +++

This bug covers the outstanding work from bug #1057617. We need to fix the url validation in the generic form to allow for:

1. about: urls
2. chrome:// urls

Thus it should support (and we should have tests for) the following schemes:

1. protocol-less. e.g. example.com
2. http/https: e.g. http://example.com
3. ftp: e.g. ftp://example.com
4. about: e.g. about:mozilla
5. chrome: e.g. chrome://foo
This should get fixed soon. Bumping it up priority-wise.
Priority: -- → P2
Bumping to 2015q1 because we're out of time for 2014q4.
Whiteboard: u=user c=feedback p=2 s=input.2014q4 → u=user c=feedback p=2 s=input.2015q1
Assigning to L. Guruprasad.

In a PR: https://github.com/mozilla/fjord/pull/428
Assignee: nobody → lgp171188
Mentor: willkg
Status: NEW → ASSIGNED
Whiteboard: u=user c=feedback p=2 s=input.2015q1 → u=user c=feedback p= s=input.2015q1
Updated smoketests for about: and chrome:// urls: https://github.com/mozilla/fjord/commit/2b58388da060553166086fcef050e0de17787223

Updated smoketests for leading/trailing whitespace: https://github.com/mozilla/fjord/commit/6a1ad6d60aaea9f8c0c38f52784e38b4a7c87304

Pushed it to production just now. Marking as FIXED.

Thank you!
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Ricky noticed smoketests were failing on his machine. I poked around and discovered I forgot about generic_feedback_dev.js which is currently live locally and in prod, but not in stage.

PR to update generic_feedback_dev.js: https://github.com/mozilla/fjord/pull/432
Pushed the generic_feedback_dev.js fix and verified correctness. Yay!
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.