Closed Bug 1091368 Opened 10 years ago Closed 10 years ago

Make 10.8 non-default on Try

Categories

(Infrastructure & Operations Graveyard :: CIDuty, task)

x86_64
macOS
task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: coop, Assigned: coop)

Details

Attachments

(2 files)

Our tiny mtnlion (10.8) test pool is falling behind under the daily load.

As a stop-gap measure until we stand-up testing on 10.10 on new hardware, I propose we disable testing on 10.8 by default on try. If a dev explicitly asks for mtnlion testing, they should still get it, but not specifying a platform or selecting all should not.
From email thread with Armen:

IIUC appending try-nondefault to a builder's pretty name should do the trick:
"'Rev3 MacOSX Leopard 9.0 try-nondefault'"

I only see some build jobs using the flag "try_by_default".

http://hg.mozilla.org/build/buildbotcustom/file/default/misc.py#l1177
http://hg.mozilla.org/build/buildbotcustom/file/48925e7e31e8/try_parser.py#l350
(In reply to Chris Cooper [:coop] from comment #1) 
> I only see some build jobs using the flag "try_by_default".

AFAICT, try_by_default is only currently used by (and possibly only affects) build platforms, i.e. I see it specified in mozilla/config.py, but not in mozilla-tests/config.py.
There's no example of us using try_by_default for test slave_platforms yet, but based on my reading of https://hg.mozilla.org/build/buildbotcustom/file/0b4b67498d8c/misc.py#l2513 , this patch should do what we need.
Assignee: nobody → coop
Status: NEW → ASSIGNED
Attachment #8514540 - Flags: review?(rail)
Attachment #8514540 - Flags: review?(rail) → review+
Comment on attachment 8514540 [details] [diff] [review]
No Mountain Lion (10.8) tests on try by default

Review of attachment 8514540 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/buildbot-configs/rev/f17a02d3b10c
Attachment #8514540 - Flags: checked-in+
I presume our trychooser story for the people (who are absolutely 100% certain to exist, because both graphics and OS API usage vary between 10.6 and 10.8) who have been backed out because their green try push didn't tell them that they were orange on 10.8 will be "just check the 10.8 box in the 'restrict' column," but what's our story for people who know going in that they need a -p all that actually is all? Check every box in the restrict column? Somehow know that the magic phrase is "-u all[]"?
(In reply to Phil Ringnalda (:philor) from comment #5)
> I presume our trychooser story for the people (who are absolutely 100%
> certain to exist, because both graphics and OS API usage vary between 10.6
> and 10.8) who have been backed out because their green try push didn't tell
> them that they were orange on 10.8 will be "just check the 10.8 box in the
> 'restrict' column," but what's our story for people who know going in that
> they need a -p all that actually is all? Check every box in the restrict
> column? Somehow know that the magic phrase is "-u all[]"?

I will update the trychooser to alert people that 10.8 is no longer on by default.
Component: General Automation → Buildduty
QA Contact: catlee → bugspam.Callek
A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/81858190
A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/82064746
Attachment #8517831 - Flags: review?(pmoore) → review+
Comment on attachment 8517831 [details] [diff] [review]
Indicate that 10.8 is not enabled by default in trychooser

Review of attachment 8517831 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/tools/rev/794dbf8b9ead
Attachment #8517831 - Flags: checked-in+
(In reply to Chris Cooper [:coop] from comment #11)
> Comment on attachment 8517831 [details] [diff] [review]
> Indicate that 10.8 is not enabled by default in trychooser
> 
> Review of attachment 8517831 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> https://hg.mozilla.org/build/tools/rev/794dbf8b9ead

Deployed to trychooser.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
(In reply to Phil Ringnalda (:philor) from comment #5)
> Somehow know that the magic phrase is "-u all[]"?

Because I keep coming across this and having to relearn, the magic phrase is actually "-u all[-platypus]" (until b2g uses that as the name of one of their builds, of course).
Product: Release Engineering → Infrastructure & Operations
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: