Closed Bug 1087608 Opened 10 years ago Closed 8 years ago

Intermittent test_gesture_tracker.html | Test timed out | test_live_regions.html,test_pointer_relay.html | uncaught exception - Error: Only one top-level window could used with AccessFu at resource://gre/modules/accessibility/Utils.jsm:43

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla48
Tracking Flags:
Tracking Status
firefox46 --- fixed
firefox47 --- fixed
firefox48 --- fixed
firefox-esr45 46+ fixed

People

(Reporter: RyanVM, Assigned: yzen)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 2 obsolete files)

1087608 patch v2
7.29 KB, patch
eeejay
: review+
ritu
: approval-mozilla-aurora+
lizzard
: approval-mozilla-beta+
ritu
: approval-mozilla-esr45+
Details | Diff | Splinter Review 
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=518711&repo=mozilla-central

builder 	Windows XP 32-bit mozilla-central pgo test mochitest-other
buildid 	20141022030202
builduid 	3660c59114264c4fb1821627e5ea365d
results 	warnings (1)
revision 	ae4d9b4ff2ee
slave 		t-xp32-ix-003
starttime 	Wed Oct 22 2014 08:17:19 GMT-0400 (Eastern Standard Time)

04:37:05 INFO - 251 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_gesture_tracker.html | undefined assertion name
04:37:05 INFO - 252 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_gesture_tracker.html | Received correct mozAccessFuGesture: {"type":"explore"}.
04:37:05 INFO - 253 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_gesture_tracker.html | undefined assertion name
04:37:05 INFO - 254 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_gesture_tracker.html | Received correct mozAccessFuGesture: {"type":"exploreend"}.
04:37:05 INFO - 255 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_gesture_tracker.html | undefined assertion name
04:37:05 INFO - 256 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_gesture_tracker.html | Received correct mozAccessFuGesture: {"type":"dwell"}.
04:37:05 INFO - 257 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_gesture_tracker.html | undefined assertion name
04:37:05 INFO - 258 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_gesture_tracker.html | Received correct mozAccessFuGesture: {"type":"explore"}.
04:37:05 INFO - 259 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_gesture_tracker.html | undefined assertion name
04:37:05 INFO - 260 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_gesture_tracker.html | Received correct mozAccessFuGesture: {"type":"explore"}.
04:37:05 INFO - 261 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_gesture_tracker.html | undefined assertion name
04:37:05 INFO - 262 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_gesture_tracker.html | Received correct mozAccessFuGesture: {"type":"exploreend"}.
04:37:05 INFO - 263 INFO Got swipeleft waiting for explore
04:37:05 INFO - 264 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_gesture_tracker.html | Test timed out. - expected PASS
04:37:06 INFO - 265 INFO TEST-OK | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_gesture_tracker.html | took 314097ms
04:37:06 INFO - 266 INFO TEST-START | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_landmarks.html
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 0
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance 1
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance
04:37:06 INFO - [AccessFu] INFO pref changed accessibility.accessfu.utterance
04:37:06 INFO - 267 INFO TEST-OK | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_landmarks.html | took 132ms
04:37:06 INFO - 268 INFO TEST-START | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_live_regions.html
04:37:06 INFO - 269 INFO must wait for load
04:37:06 INFO - 270 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_live_regions.html | uncaught exception - Error: Only one top-level window could used with AccessFu at resource://gre/modules/accessibility/Utils.jsm:43
Inactive; closing (see bug 1180138).
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
See Also: → 1186675
This bug also seems to be frequently associated with massive leaks (bug 1186675).

It looks like this is one of the top ten most frequent unfixed failures on Orange Factor.

David, is there somebody who could look into this? Thanks.
Flags: needinfo?(dbolter)
Yura, Eitan what is the best way forward here? Possible fix, or can we stop the bleeding somehow?
Flags: needinfo?(yzenevich)
Flags: needinfo?(eitan)
Flags: needinfo?(dbolter)
I will try to either fix it by the end of the week, if not I will disable it for the time being.
Assignee: nobody → yzenevich
Flags: needinfo?(yzenevich)
Flags: needinfo?(eitan)
---
 accessible/jsat/AccessFu.jsm                  | 15 ++++++++---
 accessible/tests/mochitest/jsat/dom_helper.js | 13 +++-------
 accessible/tests/mochitest/jsat/jsatcommon.js | 36 ++++++++++++++++-----------
 3 files changed, 37 insertions(+), 27 deletions(-)

Review commit: https://reviewboard.mozilla.org/r/32565/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32565/
Attachment #8712507 - Flags: review?(eitan)
Comment on attachment 8712507 [details]
MozReview Request: Bug 1087608 - ensuring multitap gestures do not resolve to explore. Updating gestures to classes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32565/diff/1-2/
Comment on attachment 8712507 [details]
MozReview Request: Bug 1087608 - ensuring multitap gestures do not resolve to explore. Updating gestures to classes.

https://reviewboard.mozilla.org/r/32565/#review29377

Looks great!
Attachment #8712507 - Flags: review?(eitan)
Comment on attachment 8712507 [details]
MozReview Request: Bug 1087608 - ensuring multitap gestures do not resolve to explore. Updating gestures to classes.

https://reviewboard.mozilla.org/r/32565/#review29411
Attachment #8712507 - Flags: review+
Comment on attachment 8712507 [details]
MozReview Request: Bug 1087608 - ensuring multitap gestures do not resolve to explore. Updating gestures to classes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32565/diff/2-3/
https://hg.mozilla.org/mozilla-central/rev/a152a1cbdcf0
Status: REOPENED → RESOLVED
Closed: 9 years ago → 8 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Might have slowed it down a little, not sure, but didn't fix it.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Could you look at this some more please? This failure happened almost 70 times last week. Thanks.
Flags: needinfo?(yzenevich)
Ill take a look shortly .
Attachment #8712507 - Attachment is obsolete: true
Flags: needinfo?(yzenevich)
Comment on attachment 8712507 [details]
MozReview Request: Bug 1087608 - ensuring multitap gestures do not resolve to explore. Updating gestures to classes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/32565/diff/3-4/
Attachment #8712507 - Attachment description: MozReview Request: Bug 1087608 - eliminating a pref observer leak and fixing test timeout overflow that cause intermittents. r=eeejay → MozReview Request: Bug 1087608 - ensuring multitap gestures do not resolve to explore. Updating gestures to classes.
Attachment #8712507 - Attachment is obsolete: false
Attachment #8712507 - Attachment is obsolete: true
Attached patch 1087608 patch (obsolete) — — Splinter Review 
Looks like mozreview for reopened bugs is a little confusing. Attaching a file instead. I did the following:
* Updated to using DOM promises instead of Promise.jsm
* Updated to classes
* Updated DoubleTap and TrippleTap to never reject to Explore (I believe that should be correct?)
I would like to try this patch and see how the tests run (the intermittent triple swipe test failure stopped happening on my machine).
Attachment #8733070 - Flags: review?(eitan)
Have you actually tested this on Android?

Since this is a stability issue, I would prefer if we first fixed the test or feature before doing a major refactor. I think we should resolve this bug ub the least disruptive way possible. Once we get a reliable test there could be a spinoff bug with the maintenance bits (classes and DOM promises).
(In reply to Eitan Isaacson [:eeejay] from comment #61)
> Have you actually tested this on Android?
> 
> Since this is a stability issue, I would prefer if we first fixed the test
> or feature before doing a major refactor. I think we should resolve this bug
> ub the least disruptive way possible. Once we get a reliable test there
> could be a spinoff bug with the maintenance bits (classes and DOM promises).

Sounds good. Ill just make the changes to gesture resolution.
Attached patch 1087608 patch v2 — — Splinter Review 
Removed all the class stuff.
Attachment #8733070 - Attachment is obsolete: true
Attachment #8733070 - Flags: review?(eitan)
Attachment #8734507 - Flags: review?(eitan)
Comment on attachment 8734507 [details] [diff] [review]
1087608 patch v2

Review of attachment 8734507 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay. This looks good. Got a chance to test it on Android.
Attachment #8734507 - Flags: review?(eitan) → review+
https://hg.mozilla.org/mozilla-central/rev/3f5ed1912b14
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: mozilla47 → mozilla48
Please request Aurora/Beta/esr45 approval on this when you get a chance.
status-firefox46: --- → affected
status-firefox47: fixed → affected
status-firefox-esr45: --- → affected
Flags: needinfo?(yzenevich)
Comment on attachment 8734507 [details] [diff] [review]
1087608 patch v2

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
This patch should be fixing an intermittent failures in one of the a11y mochitests.
User impact if declined: The test failures are associated with possible incorrect gesture resolution which can (though unlikely) be seen sometimes when the user performs sequential taps in Fennec with VO.
Fix Landed on Version:
Risk to taking this patch (and alternatives if risky): Low, this patch only changes what double and triple tap gestures can resolve to.
String or UUID changes made by this patch: None

[Describe test coverage new/current, TreeHerder]: Fixes intermittents associated with this test: https://hg.mozilla.org/mozilla-central/rev/3f5ed1912b14 
[Risks and why]: Same as above
Flags: needinfo?(yzenevich)
Attachment #8734507 - Flags: approval-mozilla-esr45?
Attachment #8734507 - Flags: approval-mozilla-beta?
Attachment #8734507 - Flags: approval-mozilla-aurora?
Comment on attachment 8734507 [details] [diff] [review]
1087608 patch v2

Fixes an intermittent failure, Aurora47+, ESR45+
Attachment #8734507 - Flags: approval-mozilla-esr45?
Attachment #8734507 - Flags: approval-mozilla-esr45+
Attachment #8734507 - Flags: approval-mozilla-aurora?
Attachment #8734507 - Flags: approval-mozilla-aurora+
Comment on attachment 8734507 [details] [diff] [review]
1087608 patch v2

Fixes an annoying intermittent test failure, tested ok on m-c. 
Please uplift to beta
Attachment #8734507 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: