David Burns :automatedtester Assignee
	Description • 10 years ago

The WebDriver spec suggests we return a uuid for a session. This will simplify things if we want do things like restarts since we just pass the session back to browser and not care if the actorID changes

	David Burns :automatedtester Assignee
	Comment 1 • 10 years ago

taking this to work on as part of restarts

	David Burns :automatedtester Assignee
	Comment 2 • 10 years ago

https://tbpl.mozilla.org/?tree=Try&rev=131e0491c83d

	David Burns :automatedtester Assignee
	Comment 4 • 10 years ago

/r/321 - Bug 1073732: Allow Marionette to have sessions ids that are unique for that session; r=jgriffin

Pull down this commit:

hg pull review -r b18dfc3a745fd304bc7be4649043a7b8f5caa7d1

	Jonathan Griffin (:jgriffin)
	Comment 5 • 10 years ago

https://reviewboard.mozilla.org/r/321/#review117

::: testing/marionette/marionette-server.js
(Diff revision 1)
> +      logger.info(this.sessionId);

For clarity, let's log something like "sessionId = " + this.sessionId, rather than just the naked id.

::: testing/marionette/marionette-server.js
(Diff revision 1)
> +    if (!this.sessionId){

nit: missing space before {

::: testing/marionette/client/marionette/marionette.py
(Diff revision 1)
> -        self.session = self._send_message('newSession', 'value', capabilities=desired_capabilities)
> +        self.session = self._send_message('newSession', 'value', capabilities=desired_capabilities, sessionId=session_id)

Can we use the same kwarg both here and _send_message...i.e., session_id rather than sessionId?

::: testing/marionette/client/marionette/tests/unit/test_session.py
(Diff revision 1)
> +        caps = self.marionette.start_session(session_id="ILoveCheese")

Yum, cheese!

	David Burns :automatedtester Assignee
	Comment 7 • 10 years ago

/r/367 - Bug 1073732: Allow Marionette to have sessions ids that are unique for that session; r=jgriffin

Pull down this commit:

hg pull review -r 2e05d76d153766e39d508c60211a7a4b0eaabb10

	Jonathan Griffin (:jgriffin)
	Comment 8 • 10 years ago

https://reviewboard.mozilla.org/r/367/#review159

Ship It!

	David Burns :automatedtester Assignee
	Comment 9 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/5548373ee88b

	Carsten Book [:Tomcat]
	Comment 10 • 10 years ago

sorry Sir :) had to back this out for test failures like https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3761502&repo=mozilla-inbound

	David Burns :automatedtester Assignee
	Comment 11 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/181e0dae85b9

	Ryan VanderMeulen [:RyanVM]
	Comment 12 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/181e0dae85b9