Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Description • 10 years ago

Right now the date_delta field in the Input API get feedback endpoint only accepts values "1d", "7d" and "14d".

I did that partially because I didn't know what the helpful use cases were here and didn't have time to spend on fleshing this out.

Anyhow, Cheng and others have said that having a limited date_delta like that isn't great. It'd be better if it supported arbitrary day-deltas.

This bug covers changing the code so it can parse any "int + 'd'" value.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 1 • 10 years ago

Grabbing this to do now.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 2 • 10 years ago

In a PR: https://github.com/mozilla/fjord/pull/352

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 3 • 10 years ago

Landed in master: https://github.com/mozilla/fjord/commit/7fd52cdf8775b233de2474b78bc812c3a886c348

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 4 • 10 years ago

Pushed to prod just now.

	Will Kahn-Greene [:willkg] ET needinfo? me Assignee
	Comment 5 • 10 years ago

This should have been closed out in comment #4.