Guilherme Gonçalves [:ggp] Assignee
	Description • 10 years ago

      No description provided.

	Jeff Walden [:Waldo]
	Comment 2 • 10 years ago

Comment on attachment 8494106 [details] [diff] [review]
Use js_free to free memory allocated by JS_malloc in testXDR.cpp

Review of attachment 8494106 [details] [diff] [review]:
-----------------------------------------------------------------

I'll batch this up for my next mass-push.  Thanks!

::: js/src/jsapi-tests/testXDR.cpp
@@ +31,5 @@
>             .setFileAndLine(filename, lineno)
>             .setVersion(version);
>      JS::RootedScript script(cx);
>      JS::Compile(cx, obj, options, chars, nchars, &script);
> +    js_free(chars);

JS_free, please, for consistency with JS_malloc.

	Nicholas Nethercote [inactive]
	Comment 3 • 10 years ago

> I'll batch this up for my next mass-push.  Thanks!

Or Guilherme could upload the final patch, do a try push (assuming he has access; if not, he should probably request it at this point) and then set the "checkin-needed" flag, and then someone like RyanVM will do it.

	Guilherme Gonçalves [:ggp] Assignee
	Comment 4 • 10 years ago

I'll do it. I'm just waiting for reviews on two other similar patches (bug 1071993 and bug 1071998, in case anyone wants to steal them), then I'll do a try run with all of them applied.

	Guilherme Gonçalves [:ggp] Assignee
	Comment 5 • 10 years ago

Using JS_free, carrying over :Waldo's r+.

	Guilherme Gonçalves [:ggp] Assignee
	Comment 6 • 10 years ago

...and updating the commit message so it refers to JS_free as well. Apologies for the spam.

	Guilherme Gonçalves [:ggp] Assignee
	Comment 7 • 10 years ago

Try: https://tbpl.mozilla.org/?tree=Try&rev=b14fe43da44f

	Ryan VanderMeulen [:RyanVM]
	Comment 8 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/07e5a8d5b119

	Ryan VanderMeulen [:RyanVM]
	Comment 9 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/07e5a8d5b119