Jean-Yves Perrier [:teoli] Reporter
	Description • 10 years ago

document.visibilityState should returns "prerender" when in prerender mode.

According to this, I understand that Chrome supports it: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TwCghLHBYwA

	Samael Wang [:freesamael] (away for now) Assignee
	Comment 5 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=37aa80cec9d7

	Samael Wang [:freesamael] (away for now) Assignee
	Comment 8 • 8 years ago

Comment on attachment 8752064 [details] [diff] [review]
Part 1: Update document to support prerender visibility state. r=smaug

Hi Olli,

It seems as long as prerender flag is set correctly, it needs only minimal change to nsDocument to support "prerender" visibilityState.

Could you help to review this patch?

	Samael Wang [:freesamael] (away for now) Assignee
	Comment 9 • 8 years ago

Comment on attachment 8752065 [details] [diff] [review]
Part 2: Add test case

Hi Olli,

The test case tries to verify behaviors based on the description of the latest draft [1]:
> If doc was prerendered and has not previously transitioned to "visible", return "prerender".

It indicates visibilityState should never change back to "prerender" again after active, so the flow tests transition from prerender => visible => hidden => visible on both remote and non-remote browsers.

It also checks hidden attribute should be true when "hidden" or "prerender" [2].

Could you help to review this patch?

[1] https://w3c.github.io/page-visibility/#visibilitystate-attribute
[2] https://w3c.github.io/page-visibility/#hidden-attribute

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 10 • 8 years ago

Comment on attachment 8752064 [details] [diff] [review]
Part 1: Update document to support prerender visibility state. r=smaug

Not about this bug; just wondering if anyone supports "unloaded" state, and if so, should we too. Perhaps worth to file a bug.

	Samael Wang [:freesamael] (away for now) Assignee
	Comment 11 • 8 years ago

(In reply to Olli Pettay [:smaug] from comment #10)
> Comment on attachment 8752064 [details] [diff] [review]
> Part 1: Update document to support prerender visibility state
> 
> Not about this bug; just wondering if anyone supports "unloaded" state, and
> if so, should we too. Perhaps worth to file a bug.

I just noticed the latest draft has removed "unloaded" state, instead it simply uses hidden:
> Return "hidden" if: ... 
> 3. The user agent is to unload doc

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 12 • 8 years ago

ah, that is better. I was looking at some other version then.

	Samael Wang [:freesamael] (away for now) Assignee
	Comment 14 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eedf48a4c92a

	Samael Wang [:freesamael] (away for now) Assignee
	Comment 15 • 8 years ago

Comment on attachment 8753710 [details] [diff] [review]
Part 2: Add test case. r=smaug

split the test case into 2 so it runs on non-e10s mode

	Samael Wang [:freesamael] (away for now) Assignee
	Comment 16 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7261087db8c9

	Samael Wang [:freesamael] (away for now) Assignee
	Comment 17 • 8 years ago

rebase before checkin

	Samael Wang [:freesamael] (away for now) Assignee
	Comment 18 • 8 years ago

rebase before checkin

	Pulsebot
	Comment 19 • 8 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9b584a14402
https://hg.mozilla.org/integration/mozilla-inbound/rev/7909d0735869

	Ryan VanderMeulen [:RyanVM]
	Comment 20 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/d9b584a14402
https://hg.mozilla.org/mozilla-central/rev/7909d0735869

	Jean-Yves Perrier [:teoli] Reporter
	Comment 21 • 8 years ago

Updated:
https://developer.mozilla.org/en-US/docs/Web/API/Document/visibilityState
and
https://developer.mozilla.org/en-US/Firefox/Releases/49#DOM_HTML_DOM